Skip to content

[EXPERIMENT] inline fmt::write for Arguments without placeholders#152542

Draft
joboet wants to merge 1 commit intorust-lang:mainfrom
joboet:inline_fmt_write
Draft

[EXPERIMENT] inline fmt::write for Arguments without placeholders#152542
joboet wants to merge 1 commit intorust-lang:mainfrom
joboet:inline_fmt_write

Conversation

@joboet
Copy link
Member

@joboet joboet commented Feb 12, 2026

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 12, 2026
@joboet
Copy link
Member Author

joboet commented Feb 12, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 12, 2026
[EXPERIMENT] inline `fmt::write` for templateless `Arguments`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 12, 2026
@joboet joboet changed the title [EXPERIMENT] inline fmt::write for templateless Arguments [EXPERIMENT] inline fmt::write for Arguments without placeholders Feb 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 12, 2026

☀️ Try build successful (CI)
Build commit: 13766b5 (13766b51a2eeec4c7c9f28c33f91faf119fe8aa9, parent: 7ad4e69ad585d8ff214f7b42d01f1959eda08f40)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (13766b5): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.7% [0.4%, 1.2%] 3
Regressions ❌
(secondary)
0.3% [0.1%, 0.5%] 8
Improvements ✅
(primary)
-0.4% [-0.9%, -0.2%] 4
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.1%] 6
All ❌✅ (primary) 0.1% [-0.9%, 1.2%] 7

Max RSS (memory usage)

Results (primary -0.4%, secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [2.3%, 2.8%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.3% [-5.6%, -1.0%] 2
Improvements ✅
(secondary)
-3.3% [-4.3%, -1.3%] 3
All ❌✅ (primary) -0.4% [-5.6%, 2.8%] 4

Cycles

Results (secondary 4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
11.2% [9.9%, 13.6%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.4% [-6.9%, -3.7%] 3
All ❌✅ (primary) - - 0

Binary size

Results (primary -0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.2% [0.0%, 0.6%] 14
Regressions ❌
(secondary)
0.3% [0.0%, 0.3%] 57
Improvements ✅
(primary)
-0.3% [-1.3%, -0.0%] 16
Improvements ✅
(secondary)
-0.6% [-4.5%, -0.0%] 13
All ❌✅ (primary) -0.1% [-1.3%, 0.6%] 30

Bootstrap: 480.915s -> 484.228s (0.69%)
Artifact size: 398.15 MiB -> 396.09 MiB (-0.52%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 12, 2026
}
}

if let Some(s) = fmt.as_str() { output.write_str(s) } else { complex(output, fmt) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to use as_statically_known_str?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants