Bump submodule backtrace

[fmease]

Updates git submodule backtrace mainly to include the changes from PR rust-lang/backtrace-rs#746. Note that these changes haven't been released yet, although that shouldn't really matter or do you see it as a requirement?

Locally I've confirmed that it fixes #151548. I don't think it warrants a regression test (esp. since backtrace tests are rather fragile aren't they?).

I'm actually not sure if only bumping the version of rustc-demangle in library/std/Cargo.toml for backtrace would've sufficed 😅. I went to great lengths updating backtrace since I had to face "package version conflicts" and similar back in PR #150843 when I pointed rustc-demangle and backtrace to my personal forks. In hindsight though I guess these errors occurred for other reasons.

r? workingjubilee (rust-lang/backtrace-rs#746) or reassign

[rustbot]

workingjubilee is currently at their maximum review capacity.
They may take a while to respond.

[rustbot]

⚠️ Warning ⚠️

• Some commits in this PR modify submodules.

  If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

[rust-log-analyzer]

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    354d02aa29ac   6 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:596da3f22bcbdff2c96fd7126001278022c834c1621c5efa2ad1a7794590636c
deleted: sha256:354d02aa29acf525570c732b6e006ecf138de6d63ca525d552eb4b24880ddc6c
deleted: sha256:8b7af0e426bc2cbeeacfd96b8354d3b80016991520977197e62090e47abaede8
deleted: sha256:cadf11ef1de7fdd5eab563757942353684047f09b212dc99d6ed48e8acf34d62
deleted: sha256:569b0caf9d5285db44ccd2629a3470139eea755be423a33a54d8a24cb3926bfa
deleted: sha256:f9dc5feb048d8f9fd43137e3998f59e9acfbd76c47a4e14984d109654119e282
---
[RUSTC-TIMING] object test:false 9.711
error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:51:1
   |
51 | windows_link::link!("kernel32.dll" "system" fn lstrlenW(lpstring : PCWSTR) -> i32);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:50:1
   |
50 | windows_link::link!("kernel32.dll" "system" fn WideCharToMultiByte(codepage : u32, dwflags : u32, lpwidecharstr : PCWSTR, cchwidecha...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:49:1
   |
49 | windows_link::link!("kernel32.dll" "system" fn WaitForSingleObjectEx(hhandle : HANDLE, dwmilliseconds : u32, balertable : BOOL) -> W...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:48:1
   |
48 | windows_link::link!("kernel32.dll" "system" fn UnmapViewOfFile(lpbaseaddress : MEMORY_MAPPED_VIEW_ADDRESS) -> BOOL);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:39:1
   |
39 | windows_link::link!("kernel32.dll" "system" fn RtlCaptureContext(contextrecord : *mut CONTEXT));
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:38:1
   |
38 | windows_link::link!("kernel32.dll" "system" fn ReleaseMutex(hmutex : HANDLE) -> BOOL);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:37:1
   |
37 | windows_link::link!("kernel32.dll" "system" fn Module32NextW(hsnapshot : HANDLE, lpme : *mut MODULEENTRY32W) -> BOOL);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:36:1
   |
36 | windows_link::link!("kernel32.dll" "system" fn Module32FirstW(hsnapshot : HANDLE, lpme : *mut MODULEENTRY32W) -> BOOL);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:35:1
   |
35 | windows_link::link!("kernel32.dll" "system" fn MapViewOfFile(hfilemappingobject : HANDLE, dwdesiredaccess : FILE_MAP, dwfileoffsethi...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:34:1
   |
34 | windows_link::link!("kernel32.dll" "system" fn LoadLibraryA(lplibfilename : PCSTR) -> HMODULE);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:33:1
   |
33 | windows_link::link!("kernel32.dll" "system" fn GetProcAddress(hmodule : HMODULE, lpprocname : PCSTR) -> FARPROC);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:32:1
   |
32 | windows_link::link!("kernel32.dll" "system" fn GetCurrentThread() -> HANDLE);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:31:1
   |
31 | windows_link::link!("kernel32.dll" "system" fn GetCurrentProcessId() -> u32);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:30:1
   |
30 | windows_link::link!("kernel32.dll" "system" fn GetCurrentProcess() -> HANDLE);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:29:1
   |
29 | windows_link::link!("kernel32.dll" "system" fn CreateToolhelp32Snapshot(dwflags : CREATE_TOOLHELP_SNAPSHOT_FLAGS, th32processid : u3...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:28:1
   |
28 | windows_link::link!("kernel32.dll" "system" fn CreateMutexA(lpmutexattributes : *const SECURITY_ATTRIBUTES, binitialowner : BOOL, lp...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:27:1
   |
27 | windows_link::link!("kernel32.dll" "system" fn CreateFileMappingA(hfile : HANDLE, lpfilemappingattributes : *const SECURITY_ATTRIBUT...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:26:1
   |
26 | windows_link::link!("kernel32.dll" "system" fn CloseHandle(hobject : HANDLE) -> BOOL);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:25:1
   |
25 | windows_link::link!("dbghelp.dll" "system" fn SymSetSearchPathW(hprocess : HANDLE, searchpatha : PCWSTR) -> BOOL);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:24:1
   |
24 | windows_link::link!("dbghelp.dll" "system" fn SymSetOptions(symoptions : u32) -> u32);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:23:1
   |
23 | windows_link::link!("dbghelp.dll" "system" fn SymQueryInlineTrace(hprocess : HANDLE, startaddress : u64, startcontext : u32, startre...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:22:1
   |
22 | windows_link::link!("dbghelp.dll" "system" fn SymInitializeW(hprocess : HANDLE, usersearchpath : PCWSTR, finvadeprocess : BOOL) -> B...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:21:1
   |
21 | windows_link::link!("dbghelp.dll" "system" fn SymGetSearchPathW(hprocess : HANDLE, searchpatha : PWSTR, searchpathlength : u32) -> B...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:20:1
   |
20 | windows_link::link!("dbghelp.dll" "system" fn SymGetOptions() -> u32);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:19:1
   |
19 | windows_link::link!("dbghelp.dll" "system" fn SymGetModuleBase64(hprocess : HANDLE, qwaddr : u64) -> u64);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:18:1
   |
18 | windows_link::link!("dbghelp.dll" "system" fn SymGetLineFromInlineContextW(hprocess : HANDLE, dwaddr : u64, inlinecontext : u32, qwm...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:17:1
   |
17 | windows_link::link!("dbghelp.dll" "system" fn SymGetLineFromAddrW64(hprocess : HANDLE, dwaddr : u64, pdwdisplacement : *mut u32, lin...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:16:1
   |
16 | windows_link::link!("dbghelp.dll" "system" fn SymFunctionTableAccess64(hprocess : HANDLE, addrbase : u64) -> *mut core::ffi::c_void);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:15:1
   |
15 | windows_link::link!("dbghelp.dll" "system" fn SymFromInlineContextW(hprocess : HANDLE, address : u64, inlinecontext : u32, displacem...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:14:1
   |
14 | windows_link::link!("dbghelp.dll" "system" fn SymFromAddrW(hprocess : HANDLE, address : u64, displacement : *mut u64, symbol : *mut ...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:13:1
   |
13 | windows_link::link!("dbghelp.dll" "system" fn SymAddrIncludeInlineTrace(hprocess : HANDLE, address : u64) -> u32);
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:12:1
   |
12 | windows_link::link!("dbghelp.dll" "system" fn StackWalkEx(machinetype : u32, hprocess : HANDLE, hthread : HANDLE, stackframe : *mut ...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:11:1
   |
11 | windows_link::link!("dbghelp.dll" "system" fn StackWalk64(machinetype : u32, hprocess : HANDLE, hthread : HANDLE, stackframe : *mut ...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0433]: failed to resolve: use of unresolved module or unlinked crate `windows_link`
  --> library/std/src/../../backtrace/src/windows_sys.rs:10:1
   |
10 | windows_link::link!("dbghelp.dll" "system" fn EnumerateLoadedModulesW64(hprocess : HANDLE, enumloadedmodulescallback : PENUMLOADED_M...
   | ^^^^^^^^^^^^ use of unresolved module or unlinked crate `windows_link`

error[E0425]: cannot find function, tuple struct or tuple variant `GetCurrentProcess` in this scope
   --> library/std/src/../../backtrace/src/backtrace/win32.rs:101:28
    |
101 |     let process = unsafe { GetCurrentProcess() };
---

error[E0425]: cannot find function, tuple struct or tuple variant `CloseHandle` in this scope
  --> library/std/src/../../backtrace/src/symbolize/gimli/libs_windows.rs:41:9
   |
41 |         CloseHandle(snap);
   |         ^^^^^^^^^^^ not found in this scope
   |
help: consider importing this function through its public re-export
   |
 1 + use crate::sys::c::CloseHandle;
   |

error[E0425]: cannot find function, tuple struct or tuple variant `GetProcAddress` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:91:21
    |
 35 | / macro_rules! dbghelp {
 36 | |     (extern "system" {
 37 | |         $(fn $name:ident($($arg:ident: $argty:ty),*) -> $ret: ty;)*
 38 | |     }) => (
...   |
 91 | |                     GetProcAddress(self.dll, symbol.as_ptr()).map(|address|address as usize)
    | |                     ^^^^^^^^^^^^^^ not found in this scope
...   |
115 | | }
    | |_- in this expansion of `dbghelp!`
116 |
117 | / dbghelp! {
118 | |     extern "system" {
119 | |         fn SymGetOptions() -> u32;
120 | |         fn SymSetOptions(options: u32) -> u32;
...   |
212 | | }
    | |_- in this macro invocation
    |
help: consider importing this function through its public re-export
---

error[E0425]: cannot find function, tuple struct or tuple variant `GetCurrentProcess` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:343:38
    |
343 |         (*dbghelp).SymInitializeW()?(GetCurrentProcess(), ptr::null_mut(), TRUE);
    |                                      ^^^^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this function through its public re-export
    |
 25 + use crate::sys::c::GetCurrentProcess;
---
    |
 25 + use crate::sys::c::GetCurrentProcess;
    |

error[E0425]: cannot find function `lstrlenW` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:364:23
    |
364 |             let len = lstrlenW(search_path_buf.as_mut_ptr());
    |                       ^^^^^^^^ not found in this scope
    |
help: consider importing this function through its public re-export
    |
 25 + use crate::sys::c::lstrlenW;
    |

error[E0425]: cannot find function, tuple struct or tuple variant `GetCurrentProcess` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:378:13
    |
---

error[E0425]: cannot find function, tuple struct or tuple variant `GetCurrentProcess` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:386:41
    |
386 |         (*dbghelp).SymSetSearchPathW()?(GetCurrentProcess(), new_search_path.as_ptr());
    |                                         ^^^^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this function through its public re-export
    |
 25 + use crate::sys::c::GetCurrentProcess;
    |

error[E0425]: cannot find function `lstrlenW` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:443:31
    |
443 |     let len: usize = unsafe { lstrlenW(module_name).try_into().unwrap() };
    |                               ^^^^^^^^ not found in this scope
    |
help: consider importing this function through its public re-export
    |
 25 + use crate::sys::c::lstrlenW;
    |

error[E0425]: cannot find function, tuple struct or tuple variant `RtlCaptureContext` in this scope
   --> library/std/src/../../backtrace/src/backtrace/win32.rs:106:14
    |
106 |     unsafe { RtlCaptureContext(&mut context.0) };
    |              ^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `CreateFileMappingA` in this scope
  --> library/std/src/../../backtrace/src/symbolize/gimli/mmap_windows.rs:22:27
   |
---
   |
33 |             let ptr = MapViewOfFile(
   |                       ^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `UnmapViewOfFile` in this scope
  --> library/std/src/../../backtrace/src/symbolize/gimli/mmap_windows.rs:63:21
   |
63 |             let r = UnmapViewOfFile(MEMORY_MAPPED_VIEW_ADDRESS { Value: self.ptr });
   |                     ^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `CreateToolhelp32Snapshot` in this scope
  --> library/std/src/../../backtrace/src/symbolize/gimli/libs_windows.rs:21:20
   |
21 |         let snap = CreateToolhelp32Snapshot(TH32CS_SNAPMODULE, 0);
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Module32FirstW` in this scope
  --> library/std/src/../../backtrace/src/symbolize/gimli/libs_windows.rs:29:12
   |
29 |         if Module32FirstW(snap, &mut me) == TRUE {
   |            ^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `Module32NextW` in this scope
  --> library/std/src/../../backtrace/src/symbolize/gimli/libs_windows.rs:35:20
   |
35 |                 if Module32NextW(snap, &mut me) != TRUE {
   |                    ^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `LoadLibraryA` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:67:32
    |
 35 | / macro_rules! dbghelp {
 36 | |     (extern "system" {
 37 | |         $(fn $name:ident($($arg:ident: $argty:ty),*) -> $ret: ty;)*
 38 | |     }) => (
...   |
 67 | |                     self.dll = LoadLibraryA(lib.as_ptr());
    | |                                ^^^^^^^^^^^^ not found in this scope
...   |
115 | | }
    | |_- in this expansion of `dbghelp!`
116 |
117 | / dbghelp! {
118 | |     extern "system" {
119 | |         fn SymGetOptions() -> u32;
120 | |         fn SymSetOptions(options: u32) -> u32;
...   |
212 | | }
    | |_- in this macro invocation

error[E0425]: cannot find function, tuple struct or tuple variant `CreateMutexA` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:283:20
    |
283 |             lock = CreateMutexA(ptr::null_mut(), FALSE, name.as_ptr());
    |                    ^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `WaitForSingleObjectEx` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:294:17
    |
294 |         let r = WaitForSingleObjectEx(lock, INFINITE, FALSE);
    |                 ^^^^^^^^^^^^^^^^^^^^^ not found in this scope

error[E0425]: cannot find function, tuple struct or tuple variant `ReleaseMutex` in this scope
   --> library/std/src/../../backtrace/src/dbghelp.rs:472:21
    |

[workingjubilee]

It is always my preference to have changes in a release but I am happy to acknowledge it is merely a preference.

[workingjubilee]

I think we need to explicitly include a dependency on https://crates.io/crates/windows-link on the appropriate platform.

[clubby789]

A release would be nice to unblock #145516

[ChrisDenton]

I created a PR to fix this #151680. The problem is backtrace and std need to be updated in tandem due to changes in how we use windows-bindgen.

[fmease]

Closing in favor of #151680 (module bump + further adjustments) as well as #151660 (targeted fix for my specific issue that didn't actually need the module bump it seems ^^').