Fix typos and grammar errors in Russian text and comments by sashaodessa · Pull Request #151204 · rust-lang/rust

sashaodessa · 2026-01-16T10:22:15Z

Fixes typos, grammar errors, and removes stray characters in Russian text and English comments.

rustbot · 2026-01-16T10:22:19Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

rustbot · 2026-01-16T10:22:22Z

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

lcnr · 2026-01-16T10:32:17Z

library/coretests/benches/str/corpora.rs

         подходит как для стартапов, так и для больших компаний,\
         как для встраиваемых устройств, так и для масштабируемых\
-         web-сервисов. Мой самый большой комплимент Rust."
+         web-сервисов. Мой самый большой комплимент Rust'у."


I think you're supposed to add -y after consonants for the dative case. Not sure it's worth changing, but I don't mind it.

As a Russian person I could say that this is not worth changing, and moreover the change is seems incorrect to me

lcnr · 2026-01-16T10:32:43Z

r? @petrochenkov maybe

ShoyuVanilla · 2026-01-16T10:33:24Z

src/tools/rust-analyzer/crates/ide/src/syntax_highlighting/tests.rs

 //- minicore: fmt
 fn main() {
-    format_args!("{} {}, {} (подозрение на спам: {:.2}%)"б);
+    format_args!("{} {}, {} (подозрение на спам: {:.2}%)");


The character б here is intentional (see rust-lang/rust-analyzer#20963).

Please revert this change and the accompanying generated test data at
src/tools/rust-analyzer/crates/ide/src/syntax_highlighting/test_data/regression_20952.html.

lnicola · 2026-01-16T10:42:08Z

src/tools/rust-analyzer/crates/ide/src/syntax_highlighting/test_data/regression_20952.html

 <pre><code><span class="keyword">fn</span> <span class="function declaration">main</span><span class="parenthesis">(</span><span class="parenthesis">)</span> <span class="brace">{</span>
    <span class="macro default_library library">format_args</span><span class="macro_bang">!</span><span class="parenthesis">(</span>"{} {}, {} (подозрение на спам: {:.2}%)"б<span class="parenthesis">)</span><span class="semicolon">;</span>
-<span class="brace">}</span></code></pre>
+<span class="brace">}</span></code></pre>


Please drop the newline too. And squash to avoid merging these changes into the subtree.

Kivooeo · 2026-01-16T11:22:08Z

r? me

rust-log-analyzer · 2026-01-16T11:31:24Z

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   --> ./test_data/regression_20952.html

You can update all `expect!` tests by running:

    env UPDATE_EXPECT=1 cargo test

To update a single test, place the cursor on `expect` token and use `run` feature of rust-analyzer.

Expect:
----

<style>
body                { margin: 0; }
pre                 { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padding: 0.4em; }

.lifetime           { color: #DFAF8F; font-style: italic; }
.label              { color: #DFAF8F; font-style: italic; }
.comment            { color: #7F9F7F; }
.documentation      { color: #629755; }
.intra_doc_link     { font-style: italic; }
.injected           { opacity: 0.65 ; }
.struct, .enum      { color: #7CB8BB; }
.enum_variant       { color: #BDE0F3; }
.string_literal     { color: #CC9393; }
.field              { color: #94BFF3; }
.function           { color: #93E0E3; }
.parameter          { color: #94BFF3; }
.text               { color: #DCDCCC; }
.type               { color: #7CB8BB; }
.builtin_type       { color: #8CD0D3; }
.type_param         { color: #DFAF8F; }
.attribute          { color: #94BFF3; }
.numeric_literal    { color: #BFEBBF; }
.bool_literal       { color: #BFE6EB; }
.macro              { color: #94BFF3; }
.proc_macro         { color: #94BFF3; text-decoration: underline; }
.derive             { color: #94BFF3; font-style: italic; }
.module             { color: #AFD8AF; }
.value_param        { color: #DCDCCC; }
.variable           { color: #DCDCCC; }
.format_specifier   { color: #CC696B; }
.mutable            { text-decoration: underline; }
.escape_sequence    { color: #94BFF3; }
.keyword            { color: #F0DFAF; font-weight: bold; }
.control            { font-style: italic; }
.reference          { font-style: italic; font-weight: bold; }
.const              { font-weight: bolder; }
.unsafe             { color: #BC8383; }
.deprecated         { text-decoration: line-through; }

.invalid_escape_sequence { color: #FC5555; text-decoration: wavy underline; }
.unresolved_reference    { color: #FC5555; text-decoration: wavy underline; }
</style>
<pre><code><span class="keyword">fn</span> <span class="function declaration">main</span><span class="parenthesis">(</span><span class="parenthesis">)</span> <span class="brace">{</span>
    <span class="macro default_library library">format_args</span><span class="macro_bang">!</span><span class="parenthesis">(</span>"{} {}, {} (подозрение на спам: {:.2}%)"б<span class="parenthesis">)</span><span class="semicolon">;</span>
<span class="brace">}</span></code></pre>

----

Actual:
----

<style>
body                { margin: 0; }
pre                 { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padding: 0.4em; }

.lifetime           { color: #DFAF8F; font-style: italic; }
.label              { color: #DFAF8F; font-style: italic; }
.comment            { color: #7F9F7F; }
.documentation      { color: #629755; }
.intra_doc_link     { font-style: italic; }
.injected           { opacity: 0.65 ; }
.struct, .enum      { color: #7CB8BB; }
.enum_variant       { color: #BDE0F3; }
.string_literal     { color: #CC9393; }
.field              { color: #94BFF3; }
.function           { color: #93E0E3; }
.parameter          { color: #94BFF3; }
.text               { color: #DCDCCC; }
.type               { color: #7CB8BB; }
.builtin_type       { color: #8CD0D3; }
.type_param         { color: #DFAF8F; }
.attribute          { color: #94BFF3; }
.numeric_literal    { color: #BFEBBF; }
.bool_literal       { color: #BFE6EB; }
.macro              { color: #94BFF3; }
.proc_macro         { color: #94BFF3; text-decoration: underline; }
.derive             { color: #94BFF3; font-style: italic; }
.module             { color: #AFD8AF; }
.value_param        { color: #DCDCCC; }
.variable           { color: #DCDCCC; }
.format_specifier   { color: #CC696B; }
.mutable            { text-decoration: underline; }
.escape_sequence    { color: #94BFF3; }
.keyword            { color: #F0DFAF; font-weight: bold; }
.control            { font-style: italic; }
.reference          { font-style: italic; font-weight: bold; }
.const              { font-weight: bolder; }
.unsafe             { color: #BC8383; }
.deprecated         { text-decoration: line-through; }

.invalid_escape_sequence { color: #FC5555; text-decoration: wavy underline; }
.unresolved_reference    { color: #FC5555; text-decoration: wavy underline; }
</style>
<pre><code><span class="keyword">fn</span> <span class="function declaration">main</span><span class="parenthesis">(</span><span class="parenthesis">)</span> <span class="brace">{</span>
    <span class="macro default_library library">format_args</span><span class="macro_bang">!</span><span class="parenthesis">(</span>"{} {}, {} (подозрение на спам: {:.2}%)"б<span class="parenthesis">)</span><span class="semicolon">;</span>
<span class="brace">}</span></code></pre>
----

Diff:
----

<style>
body                { margin: 0; }
pre                 { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padding: 0.4em; }

.lifetime           { color: #DFAF8F; font-style: italic; }
.label              { color: #DFAF8F; font-style: italic; }
.comment            { color: #7F9F7F; }
.documentation      { color: #629755; }
.intra_doc_link     { font-style: italic; }
.injected           { opacity: 0.65 ; }
.struct, .enum      { color: #7CB8BB; }
.enum_variant       { color: #BDE0F3; }
.string_literal     { color: #CC9393; }
.field              { color: #94BFF3; }
.function           { color: #93E0E3; }
.parameter          { color: #94BFF3; }
.text               { color: #DCDCCC; }
.type               { color: #7CB8BB; }
.builtin_type       { color: #8CD0D3; }
.type_param         { color: #DFAF8F; }
.attribute          { color: #94BFF3; }
.numeric_literal    { color: #BFEBBF; }
.bool_literal       { color: #BFE6EB; }
.macro              { color: #94BFF3; }
.proc_macro         { color: #94BFF3; text-decoration: underline; }
.derive             { color: #94BFF3; font-style: italic; }
.module             { color: #AFD8AF; }
.value_param        { color: #DCDCCC; }
.variable           { color: #DCDCCC; }
.format_specifier   { color: #CC696B; }
.mutable            { text-decoration: underline; }
.escape_sequence    { color: #94BFF3; }
.keyword            { color: #F0DFAF; font-weight: bold; }
.control            { font-style: italic; }
.reference          { font-style: italic; font-weight: bold; }
.const              { font-weight: bolder; }
.unsafe             { color: #BC8383; }
.deprecated         { text-decoration: line-through; }

.invalid_escape_sequence { color: #FC5555; text-decoration: wavy underline; }
.unresolved_reference    { color: #FC5555; text-decoration: wavy underline; }
</style>
<pre><code><span class="keyword">fn</span> <span class="function declaration">main</span><span class="parenthesis">(</span><span class="parenthesis">)</span> <span class="brace">{</span>
    <span class="macro default_library library">format_args</span><span class="macro_bang">!</span><span class="parenthesis">(</span>"{} {}, {} (подозрение на спам: {:.2}%)"б<span class="parenthesis">)</span><span class="semicolon">;</span>
<span class="brace">}</span></code></pre>

----

---- syntax_highlighting::tests::regression_20952 stdout end ----

failures:
    syntax_highlighting::tests::regression_20952

test result: FAILED. 1262 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 760.37ms

sashaodessa added 4 commits January 16, 2026 11:14

Update link.rs

c2141ae

Update corpora.rs

7a11ca7

Update tests.rs

5351abe

Update regression_20952.html

a82b36a

rustbot assigned lcnr Jan 16, 2026

lcnr reviewed Jan 16, 2026

View reviewed changes

rustbot assigned petrochenkov and unassigned lcnr Jan 16, 2026

ShoyuVanilla reviewed Jan 16, 2026

View reviewed changes

sashaodessa added 2 commits January 16, 2026 11:40

Update regression_20952.html

2763cf4

Update tests.rs

1ff399c

lnicola reviewed Jan 16, 2026

View reviewed changes

rustbot assigned Kivooeo and unassigned petrochenkov Jan 16, 2026

reddevilmidzy added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix typos and grammar errors in Russian text and comments#151204

Fix typos and grammar errors in Russian text and comments#151204
sashaodessa wants to merge 6 commits intorust-lang:mainfrom
sashaodessa:main

sashaodessa commented Jan 16, 2026

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

lcnr Jan 16, 2026

Uh oh!

lnicola Jan 16, 2026 •

edited

Loading

Uh oh!

Kivooeo Jan 16, 2026

Uh oh!

lcnr commented Jan 16, 2026

Uh oh!

ShoyuVanilla Jan 16, 2026

Uh oh!

lnicola Jan 16, 2026

Uh oh!

Kivooeo commented Jan 16, 2026

Uh oh!

rust-log-analyzer commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

sashaodessa commented Jan 16, 2026

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

rustbot commented Jan 16, 2026

Uh oh!

lcnr Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

lnicola Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

lcnr commented Jan 16, 2026

Uh oh!

ShoyuVanilla Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

lnicola Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Jan 16, 2026

Uh oh!

rust-log-analyzer commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

lnicola Jan 16, 2026 •

edited

Loading