Correct library linking for hexagon targets in run-make tests#150010
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 15, 2025
Merged
Correct library linking for hexagon targets in run-make tests#150010bors merged 1 commit intorust-lang:mainfrom
bors merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
The run-make-support library was changed cc @jieyouxu |
Collaborator
This comment has been minimized.
This comment has been minimized.
Fixes the run-make test framework to use target-specific library linking instead of host-based detection. Previously, tests for hexagon targets failed because the framework used uname() to detect libraries to link, which returned Linux libraries (-lm -lrt -ldl -lpthread) that don't exist on all hexagon targets. - Use target() instead of uname() to detect cross-compilation targets - Add hexagon-specific library configuration (-lunwind -lclang_rt.builtins-hexagon) - Maintain backward compatibility for host-native compilation This enables hexagon tests to compile and link successfully with the appropriate runtime libraries for the hexagon platform.
dc68311 to
bf9a874
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 15, 2025
Rollup of 7 pull requests Successful merges: - #149744 (test: update duplicate many_digits test to use f64 instead of f32) - #149946 (mir_build: Move and rename code for partitioning match candidates) - #149987 (Move ambient cdb discovery from compiletest to bootstrap) - #149990 (Improve amdgpu docs: Mention device-libs and xnack) - #149994 (Allow vector types for amdgpu) - #149997 (Link POSIX instead of Linux manual for Instant) - #150010 (Correct library linking for hexagon targets in run-make tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 15, 2025
Rollup merge of #150010 - androm3da:bcain/make_test_linkage, r=jieyouxu Correct library linking for hexagon targets in run-make tests Fixes the run-make test framework to use target-specific library linking instead of host-based detection. Previously, tests for hexagon targets failed because the framework used uname() to detect libraries to link, which returned Linux libraries (-lm -lrt -ldl -lpthread) that don't exist on all hexagon targets. - Use target() instead of uname() to detect cross-compilation targets - Add hexagon-specific library configuration (-lunwind -lclang_rt.builtins-hexagon) - Maintain backward compatibility for host-native compilation This enables hexagon tests to compile and link successfully with the appropriate runtime libraries for the hexagon platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the run-make test framework to use target-specific library linking instead of host-based detection. Previously, tests for hexagon targets failed because the framework used uname() to detect libraries to link, which returned Linux libraries (-lm -lrt -ldl -lpthread) that don't exist on all hexagon targets.
This enables hexagon tests to compile and link successfully with the appropriate runtime libraries for the hexagon platform.