std: sys: fs: uefi: Implement rmdir and unlink

[Ayush1325]

• Implement remove_dir and remove_file.
• Tested on qemu ovmf.

[rustbot]

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Ayush1325]

@rustbot label +O-UEFI

[joboet]

I think the error messages could be more descriptive. And in any case, they should start in lowercase. Apart from that, this looks fine!

View changes since this review

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Ayush1325]

I think the error messages could be more descriptive. And in any case, they should start in lowercase. Apart from that, this looks fine!

I have updated the error messages.

[joboet]

@bors r+

[bors]

📌 Commit 5b0fded has been approved by joboet

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5b0fded with merge 0ad2cd3...

[bors]

☀️ Test successful - checks-actions
Approved by: joboet
Pushing 0ad2cd3 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 791c041 (parent) -> 0ad2cd3 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0ad2cd3f1357da47c3eb4acc8224a8f10dd87d0f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. aarch64-apple: 9063.5s -> 7086.6s (-21.8%)
2. x86_64-gnu-distcheck: 6206.2s -> 6968.0s (+12.3%)
3. x86_64-gnu-llvm-20-3: 5753.2s -> 6368.5s (+10.7%)
4. x86_64-msvc-2: 6502.0s -> 7148.4s (+9.9%)
5. aarch64-gnu-llvm-20-1: 3383.7s -> 3645.1s (+7.7%)
6. dist-x86_64-apple: 6875.3s -> 6352.0s (-7.6%)
7. dist-aarch64-apple: 6107.0s -> 6571.5s (+7.6%)
8. test-various: 7005.0s -> 6481.7s (-7.5%)
9. aarch64-gnu-llvm-20-2: 2340.0s -> 2186.3s (-6.6%)
10. dist-x86_64-solaris: 5392.5s -> 5050.9s (-6.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (0ad2cd3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.3%	[5.3%, 5.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	5.3%	[5.3%, 5.3%]	1

Cycles

Results (primary -2.5%, secondary 7.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.3%	[7.3%, 7.3%]	1
Improvements ✅ (primary)	-2.5%	[-2.6%, -2.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.5%	[-2.6%, -2.5%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.18s -> 471.605s (-0.33%)
Artifact size: 386.88 MiB -> 386.91 MiB (0.01%)