Skip to content

stabilize duration_from_nanos_u128#148587

Merged
bors merged 1 commit intorust-lang:mainfrom
RalfJung:duration_from_nanos_u128
Nov 13, 2025
Merged

stabilize duration_from_nanos_u128#148587
bors merged 1 commit intorust-lang:mainfrom
RalfJung:duration_from_nanos_u128

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 6, 2025

libs-api FCP passed in #139201.
Closes #139201.

@oli-obk would you prefer if we did a const-hack to avoid allowing const_trait_impl here?

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

⚠️ #[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

cc @rust-lang/wg-const-eval

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Nov 9, 2025

r=me (unless you want to wait for Oli's response)

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned Mark-Simulacrum Nov 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

@RalfJung
Copy link
Member Author

RalfJung commented Nov 9, 2025

Oli was fine with rustc_allow_const_fn_unstable(const_trait_impl) in #148478.

But no need to rush, we can wait a bit here.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 13, 2025

@bors r=Mark-Simulacrum,oli-obk

@bors
Copy link
Collaborator

bors commented Nov 13, 2025

📌 Commit b032fac has been approved by Mark-Simulacrum,oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 13, 2025
@GuillaumeGomez
Rollup merge of rust-lang#148587 - RalfJung:duration_from_nanos_u128,…
1fe6ee3 
… r=Mark-Simulacrum,oli-obk

stabilize duration_from_nanos_u128

libs-api FCP passed in rust-lang#139201.
Closes rust-lang#139201.

`@oli-obk` would you prefer if we did a const-hack to avoid allowing `const_trait_impl` here?
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 13, 2025
Closed
bors added a commit that referenced this pull request Nov 13, 2025
@bors
Auto merge of #148903 - GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27 
Rollup of 4 pull requests

Successful merges:

 - #148587 (stabilize duration_from_nanos_u128)
 - #148638 (Fix ICE for repr simd on non struct)
 - #148808 (Some resolve cleanups)
 - #148901 (Disable rustdoc-test-builder test partially for SGX target.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Nov 13, 2025

⌛ Testing commit b032fac with merge af5c5b7...

@bors
Copy link
Collaborator

bors commented Nov 13, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum,oli-obk
Pushing af5c5b7 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 13, 2025
@bors bors merged commit af5c5b7 into rust-lang:main Nov 13, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d682af8 (parent) -> af5c5b7 (this PR)

Test differences

Show 143 test diffs

143 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard af5c5b74c8f2c0b1dfd9a201453bf2df538e93e0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 8641.4s -> 5534.5s (-36.0%)
  2. aarch64-apple: 7325.6s -> 9851.7s (+34.5%)
  3. pr-check-1: 1512.9s -> 1303.1s (-13.9%)
  4. i686-gnu-2: 5585.4s -> 5004.4s (-10.4%)
  5. x86_64-gnu-aux: 6010.0s -> 6618.4s (+10.1%)
  6. dist-i686-msvc: 7948.9s -> 8579.4s (+7.9%)
  7. x86_64-rust-for-linux: 2700.4s -> 2488.7s (-7.8%)
  8. dist-i686-linux: 6529.9s -> 6029.3s (-7.7%)
  9. dist-x86_64-apple: 7933.3s -> 8474.7s (+6.8%)
  10. dist-loongarch64-linux: 5545.3s -> 5173.4s (-6.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@RalfJung RalfJung deleted the duration_from_nanos_u128 branch November 13, 2025 18:52
@rust-timer
Copy link
Collaborator

rust-timer commented Nov 13, 2025

Finished benchmarking commit (af5c5b7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.0% [4.0%, 4.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.838s -> 475.694s (0.60%)
Artifact size: 388.40 MiB -> 388.39 MiB (-0.00%)

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge of rust-lang#148587 - RalfJung:duration_from_nanos_u128, r…
dbcde70 
…=Mark-Simulacrum,oli-obk

stabilize duration_from_nanos_u128

libs-api FCP passed in rust-lang#139201.
Closes rust-lang#139201.

`@oli-obk` would you prefer if we did a const-hack to avoid allowing `const_trait_impl` here?
makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge of rust-lang#148587 - RalfJung:duration_from_nanos_u128, r…
960a95a 
…=Mark-Simulacrum,oli-obk

stabilize duration_from_nanos_u128

libs-api FCP passed in rust-lang#139201.
Closes rust-lang#139201.

`@oli-obk` would you prefer if we did a const-hack to avoid allowing `const_trait_impl` here?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for Duration::from_nanos_u128

6 participants

@RalfJung @rustbot @Mark-Simulacrum @oli-obk @bors @rust-timer