Merged
Conversation
The first statement of the block might have been in a different context from the expression. Walk up to the right context to get bounds properly. Also, switch to `snippet_with_applicability()` since we know that we are in the right context already.
`option_map_unwrap_or` and `seek_rewind` are not current lints, and cannot be referenced as having the `msrv` configuration option.
Before this change, the suggestion for `Option.or(Some(vec![])).unwrap()` expanded the `vec!` macro which broke the code, both in terms of readability, and because the expansion references `$crate` which cannot be inlined.
use trait item's HirId when emitting lint at `check_item` level changelog: [`missing_inline_in_public_items`]: fix trait item lint emission Signed-off-by: Zihan <zihanli0822@gmail.com>
avoids bounds checks
`None` is the fallback case anyway
to be able to reuse `did`
`trait_name` can only be _one_ of those at the same time
…ang#15540) changelog: [`ptr_cast_constness`]: avoid suggesting unresolvable method call Spell check says "unresolvable" isn't a word. Which repository do I open a PR against to fix that? Fixes rust-lang/rust-clippy#11317
…rors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
Forgot to do this at the start of the week. Will be back on the 15th. (That's also the reason why I forgot about the meeting. Sorry for that!) r? @ghost changelog: none
r? @ghost changelog: integer-to-pointer-transmutes are now handled by the upstream `integer_to_ptr_transmutes` Rust lint and no longer by the [`useless_transmute`] Clippy lint
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Collaborator
|
Member
Author
🤔 Closing and reopening to restart PR CI |
Member
|
@bors r+ p=1 rollup=never |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b3cfb8f (parent) -> 91edc3e (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 91edc3ebccc4daa46c20a93f4709862376da1fdd --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (91edc3e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.7%, secondary 3.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 467.377s -> 468.177s (0.17%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Manishearth