Extended temporary argument to format_args!() in all cases

[m-ou-se]

Fixes #145880 by removing the special case.

Reference PR:

• Remove caveats related to format_args! expansion reference#2017

[rustbot]

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Some changes occurred in coverage tests.

cc @Zalathar

[m-ou-se]

@bors try @rust-timer queue

[m-ou-se]

This should not be merged before #145838 is merged, to not make that problem worse.

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[rust-bors]

☀️ Try build successful (CI)
Build commit: a6a9c2f (a6a9c2fdb3e18f9e2288248b96b10108f7a262b0, parent: 4356e83c77cb28113411fb8e2219127f708095b5)

[rust-timer]

Finished benchmarking commit (a6a9c2f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	9
Regressions ❌ (secondary)	0.7%	[0.1%, 2.9%]	12
Improvements ✅ (primary)	-1.1%	[-1.7%, -0.7%]	5
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-0.2%	[-1.7%, 0.5%]	14

Max RSS (memory usage)

Results (primary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[0.4%, 4.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.9%	[-3.9%, -3.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-3.9%, 4.0%]	3

Cycles

Results (secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[1.9%, 3.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	49
Regressions ❌ (secondary)	0.8%	[0.0%, 3.9%]	22
Improvements ✅ (primary)	-0.1%	[-0.3%, -0.0%]	10
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	4
All ❌✅ (primary)	0.0%	[-0.3%, 0.3%]	59

Bootstrap: 468.126s -> 469.353s (0.26%)
Artifact size: 391.18 MiB -> 391.15 MiB (-0.01%)

[petrochenkov]

Blocked on #145838.
@rustbot blocked

[traviscross]

@rustbot ready

This is unblocked as #145838 has been approved.

[petrochenkov]

@bors r+

[bors]

📌 Commit 663ca24 has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 663ca24 with merge 40ace17...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 40ace17 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b733736 (parent) -> 40ace17 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 40ace17fc3891155bad26a50d60a9ab07b83bf8e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-apple-various: 4332.4s -> 3411.6s (-21.3%)
2. i686-msvc-2: 7161.3s -> 8144.2s (13.7%)
3. dist-x86_64-apple: 8548.8s -> 7471.5s (-12.6%)
4. x86_64-mingw-2: 7593.3s -> 8464.7s (11.5%)
5. x86_64-rust-for-linux: 2853.8s -> 2593.0s (-9.1%)
6. x86_64-gnu-distcheck: 7006.0s -> 6374.8s (-9.0%)
7. dist-aarch64-apple: 6149.5s -> 6671.7s (8.5%)
8. x86_64-gnu-llvm-20-1: 3495.8s -> 3211.8s (-8.1%)
9. x86_64-gnu-nopt: 7477.3s -> 6873.6s (-8.1%)
10. dist-i686-msvc: 8510.5s -> 7853.4s (-7.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[jieyouxu]

Does this need relnotes? I suppose we are accepting more code (#145880) than before, right?

[rust-timer]

Finished benchmarking commit (40ace17): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.8%]	15
Regressions ❌ (secondary)	0.5%	[0.0%, 2.9%]	19
Improvements ✅ (primary)	-1.0%	[-1.7%, -0.4%]	5
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	3
All ❌✅ (primary)	0.0%	[-1.7%, 0.8%]	20

Max RSS (memory usage)

Results (primary 1.8%, secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[0.8%, 5.4%]	4
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.8%	[-1.8%, 5.4%]	5

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[1.3%, 4.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.6%]	44
Regressions ❌ (secondary)	0.8%	[0.0%, 3.8%]	21
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	11
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.0%]	5
All ❌✅ (primary)	0.1%	[-0.2%, 0.6%]	55

Bootstrap: 472.685s -> 471.524s (-0.25%)
Artifact size: 388.17 MiB -> 388.09 MiB (-0.02%)