Regression test for bad codegen of #[derive(Clone)] on enums#144961
Open
lucarlig wants to merge 1 commit intorust-lang:mainfrom
Open
Regression test for bad codegen of #[derive(Clone)] on enums#144961lucarlig wants to merge 1 commit intorust-lang:mainfrom
#[derive(Clone)] on enums#144961lucarlig wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Mark-Simulacrum
requested changes
Aug 21, 2025
| } | ||
|
|
||
| // CHECK-LABEL: @clone_bar | ||
| // CHECK-NOT: icmp |
Member
There was a problem hiding this comment.
Can you adjust this to specifically check this is just a load + ret? That should be fairly future proof and avoids any regressions if this is something that's more complex but not an icmp.
%0 = load i16, ptr %b, align 1
ret i16 %0
Member
|
@lucarlig any updates on this? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added regression test using LLVM IR
https://rust.godbolt.org/z/7qcEKPf3e
Fixes #69174