Rename begin_panic to panic_with_payload#144902
Rename begin_panic to panic_with_payload#144902Kivooeo wants to merge 1 commit intorust-lang:mainfrom
begin_panic to panic_with_payload#144902Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
|
Some changes occurred to the CTFE machinery This PR modifies Some changes occurred to constck cc @fee1-dead Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
1fc546b to
8d38e92
Compare
This comment has been minimized.
This comment has been minimized.
8d38e92 to
5d10eb5
Compare
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
|
According to message above would it be reasonable to move rust-analyzer changes into it's repo? or it's fine like this |
This comment has been minimized.
This comment has been minimized.
5d10eb5 to
98d2ad4
Compare
98d2ad4 to
22e6d2b
Compare
| //! features, such as Fn family of traits. | ||
| use hir_expand::name::Name; | ||
| use intern::{Symbol, sym}; | ||
| use intern::{sym, Symbol}; |
There was a problem hiding this comment.
It looks like we're reformatting rust-analyzer code? That probably should not be made in rust-lang/rust, and instead left for upstream PR(s). Making the necessary 1-line change here seems reasonable though.
There was a problem hiding this comment.
Yep, I've asked about it above, thanks for an answer confirming it, but I will take some actions after we settle on naming, because currently according to a zullip topic we don't have consensus
This was little bit discussed here #t-libs > `begin_panic` renaming @ 💬, so I guess this is fine name
Also as far as I can say it's safe to rename because of lang item, correct me here if I'm wrong
Part of #116005