`tests/ui`: A New Order [0/28] by Kivooeo · Pull Request #143908 · rust-lang/rust

Kivooeo · 2025-07-13T21:33:25Z

Note

Intermediate commits are intended to help review, but will be squashed prior to merge.

These are the some last tests that didn’t make it into the main twenty-eightology of PRs. Part of #133895.

jieyouxu

Thanks, two nits. Please squash the test changes into one commit (i.e. only retain two commits {move, test changes} as discussed previously).

tests/ui/fmt/println-debug-different-types.rs

tests/ui/symbol-names/struct-constructor-mangling.rs

jieyouxu · 2025-07-17T08:37:22Z

@rustbot author

rustbot · 2025-07-17T08:37:26Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

tests/ui/expr/weird-exprs.rs

Reverting file name weird-exprs.rs due to its historical use, recognition in community and references

Kivooeo · 2025-07-17T13:27:51Z

@rustbot ready

also can I ask you to update tracking issue's long term block, and remove

Reorganize all the stray tests immediately under tests/ui and place them into suitable subdirectories, improving the tests themselves along the way

from there or strike through, since this one is completed

jieyouxu

Thanks!

jieyouxu · 2025-07-17T13:41:37Z

also can I ask you to update tracking issue's long term block, and remove

Reorganize all the stray tests immediately under tests/ui and place them into suitable subdirectories, improving the tests themselves along the way

from there or strike through, since this one is completed

Done.

jieyouxu · 2025-07-17T13:41:45Z

@bors r+ rollup

bors · 2025-07-17T13:41:49Z

📌 Commit c0597fb has been approved by jieyouxu

It is now in the queue for this repository.

`tests/ui`: A New Order [0/28] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. These are the some last tests that didn’t make it into the main twenty-eightology of PRs. Part of rust-lang#133895. r? `@jieyouxu`

Rollup of 12 pull requests Successful merges: - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled) - #143271 (Store the type of each GVN value) - #143280 (Remove duplicate error about raw underscore lifetime) - #143649 (Add test for `default_field_values` and `const_default`) - #143699 (Make `AsyncDrop` check that it's being implemented on a local ADT) - #143719 (Emit warning when there is no space between `-o` and arg) - #143833 (Ban projecting into SIMD types [MCP838]) - #143891 (Port `#[coverage]` to the new attribute system) - #143908 (`tests/ui`: A New Order [0/28] ) - #143909 (docs(alloc::fmt): Make type optional, instead of matching empty string) - #143925 (Make slice comparisons const) - #143997 (Use $crate in macros for rustc_public (aka stable_mir)) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui`: A New Order [0/28] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. These are the some last tests that didn’t make it into the main twenty-eightology of PRs. Part of rust-lang#133895. r? ``@jieyouxu``

Rollup of 12 pull requests Successful merges: - #143280 (Remove duplicate error about raw underscore lifetime) - #143649 (Add test for `default_field_values` and `const_default`) - #143699 (Make `AsyncDrop` check that it's being implemented on a local ADT) - #143704 (Be a bit more careful around exotic cycles in in the inliner) - #143908 (`tests/ui`: A New Order [0/28] ) - #143909 (docs(alloc::fmt): Make type optional, instead of matching empty string) - #143925 (Make slice comparisons const) - #143997 (Use $crate in macros for rustc_public (aka stable_mir)) - #144013 (resolve: Make disambiguators for underscore bindings module-local) - #144029 (Fix wrong messages from methods with the same name from different traits) - #144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels) - #144069 (ci: use windows 22 for all free runners) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - #143280 (Remove duplicate error about raw underscore lifetime) - #143649 (Add test for `default_field_values` and `const_default`) - #143699 (Make `AsyncDrop` check that it's being implemented on a local ADT) - #143908 (`tests/ui`: A New Order [0/28] ) - #143909 (docs(alloc::fmt): Make type optional, instead of matching empty string) - #143925 (Make slice comparisons const) - #143997 (Use $crate in macros for rustc_public (aka stable_mir)) - #144013 (resolve: Make disambiguators for underscore bindings module-local) - #144029 (Fix wrong messages from methods with the same name from different traits) - #144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels) - #144069 (ci: use windows 22 for all free runners) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143908 - Kivooeo:tf0, r=jieyouxu `tests/ui`: A New Order [0/28] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. These are the some last tests that didn’t make it into the main twenty-eightology of PRs. Part of #133895. r? ```@jieyouxu```

`tests/ui`: A New Order [0/28] > [!NOTE] > > Intermediate commits are intended to help review, but will be squashed prior to merge. These are the some last tests that didn’t make it into the main twenty-eightology of PRs. Part of rust-lang#133895. r? ```@jieyouxu```

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#143280 (Remove duplicate error about raw underscore lifetime) - rust-lang#143649 (Add test for `default_field_values` and `const_default`) - rust-lang#143699 (Make `AsyncDrop` check that it's being implemented on a local ADT) - rust-lang#143908 (`tests/ui`: A New Order [0/28] ) - rust-lang#143909 (docs(alloc::fmt): Make type optional, instead of matching empty string) - rust-lang#143925 (Make slice comparisons const) - rust-lang#143997 (Use $crate in macros for rustc_public (aka stable_mir)) - rust-lang#144013 (resolve: Make disambiguators for underscore bindings module-local) - rust-lang#144029 (Fix wrong messages from methods with the same name from different traits) - rust-lang#144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels) - rust-lang#144069 (ci: use windows 22 for all free runners) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - rust-lang/rust#143280 (Remove duplicate error about raw underscore lifetime) - rust-lang/rust#143649 (Add test for `default_field_values` and `const_default`) - rust-lang/rust#143699 (Make `AsyncDrop` check that it's being implemented on a local ADT) - rust-lang/rust#143908 (`tests/ui`: A New Order [0/28] ) - rust-lang/rust#143909 (docs(alloc::fmt): Make type optional, instead of matching empty string) - rust-lang/rust#143925 (Make slice comparisons const) - rust-lang/rust#143997 (Use $crate in macros for rustc_public (aka stable_mir)) - rust-lang/rust#144013 (resolve: Make disambiguators for underscore bindings module-local) - rust-lang/rust#144029 (Fix wrong messages from methods with the same name from different traits) - rust-lang/rust#144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels) - rust-lang/rust#144069 (ci: use windows 22 for all free runners) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#143280 (Remove duplicate error about raw underscore lifetime) - rust-lang#143649 (Add test for `default_field_values` and `const_default`) - rust-lang#143699 (Make `AsyncDrop` check that it's being implemented on a local ADT) - rust-lang#143908 (`tests/ui`: A New Order [0/28] ) - rust-lang#143909 (docs(alloc::fmt): Make type optional, instead of matching empty string) - rust-lang#143925 (Make slice comparisons const) - rust-lang#143997 (Use $crate in macros for rustc_public (aka stable_mir)) - rust-lang#144013 (resolve: Make disambiguators for underscore bindings module-local) - rust-lang#144029 (Fix wrong messages from methods with the same name from different traits) - rust-lang#144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels) - rust-lang#144069 (ci: use windows 22 for all free runners) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - rust-lang/rust#143280 (Remove duplicate error about raw underscore lifetime) - rust-lang/rust#143649 (Add test for `default_field_values` and `const_default`) - rust-lang/rust#143699 (Make `AsyncDrop` check that it's being implemented on a local ADT) - rust-lang/rust#143908 (`tests/ui`: A New Order [0/28] ) - rust-lang/rust#143909 (docs(alloc::fmt): Make type optional, instead of matching empty string) - rust-lang/rust#143925 (Make slice comparisons const) - rust-lang/rust#143997 (Use $crate in macros for rustc_public (aka stable_mir)) - rust-lang/rust#144013 (resolve: Make disambiguators for underscore bindings module-local) - rust-lang/rust#144029 (Fix wrong messages from methods with the same name from different traits) - rust-lang/rust#144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels) - rust-lang/rust#144069 (ci: use windows 22 for all free runners) r? `@ghost` `@rustbot` modify labels: rollup

moved tests

b7d024b

rustbot assigned jieyouxu Jul 13, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2025

jieyouxu reviewed Jul 17, 2025

View reviewed changes

tests/ui/fmt/println-debug-different-types.rs Outdated Show resolved Hide resolved

tests/ui/symbol-names/struct-constructor-mangling.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025

Kivooeo force-pushed the tf0 branch from 53543db to 113c687 Compare July 17, 2025 09:59

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf0 branch 2 times, most recently from 15f3d09 to 33b1dd3 Compare July 17, 2025 10:16

Kivooeo commented Jul 17, 2025

View reviewed changes

tests/ui/expr/weird-exprs.rs Show resolved Hide resolved

cleaned up some tests

c0597fb

Reverting file name weird-exprs.rs due to its historical use, recognition in community and references

Kivooeo force-pushed the tf0 branch from 33b1dd3 to c0597fb Compare July 17, 2025 10:53

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2025

jieyouxu approved these changes Jul 17, 2025

View reviewed changes

jieyouxu mentioned this pull request Jul 17, 2025

Tracking Issue for ui test suite improvements #133895

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025

jhpratt mentioned this pull request Jul 18, 2025

Rollup of 12 pull requests #144101

Closed

matthiaskrgr mentioned this pull request Jul 18, 2025

Rollup of 12 pull requests #144110

Closed

matthiaskrgr mentioned this pull request Jul 18, 2025

Rollup of 11 pull requests #144130

Merged

bors merged commit 0820cf8 into rust-lang:master Jul 18, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 18, 2025

This was referenced Jul 19, 2025

Tracking issue for moving ui tests to subdirectories #73494

Closed

Add a tidy check to prevent adding new test files *directly* under tests/ui/ rust-lang/compiler-team#902

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`tests/ui`: A New Order [0/28] #143908

`tests/ui`: A New Order [0/28] #143908
bors merged 2 commits intorust-lang:masterfrom
Kivooeo:tf0

Kivooeo commented Jul 13, 2025 •

edited

Loading

Uh oh!

jieyouxu left a comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

rustbot commented Jul 17, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Kivooeo commented Jul 17, 2025 •

edited

Loading

Uh oh!

jieyouxu left a comment

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

bors commented Jul 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Kivooeo commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

rustbot commented Jul 17, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Kivooeo commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

jieyouxu commented Jul 17, 2025

Uh oh!

bors commented Jul 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kivooeo commented Jul 13, 2025 •

edited

Loading

Kivooeo commented Jul 17, 2025 •

edited

Loading