Skip to content

Port #[macro_export] to the new attribute parsing infrastructure#143857

Merged
bors merged 2 commits intorust-lang:masterfrom
Periodic1911:macro-export
Sep 21, 2025
Merged

Port #[macro_export] to the new attribute parsing infrastructure#143857
bors merged 2 commits intorust-lang:masterfrom
Periodic1911:macro-export

Conversation

@Periodic1911
Copy link
Contributor

@Periodic1911 Periodic1911 commented Jul 12, 2025

Ports macro_export to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk

cc @JonathanBrouwer @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Periodic1911
Periodic1911 commented Jul 12, 2025
View reviewed changes
tests/ui/attributes/invalid_macro_export_argument.rs Outdated
}

#[macro_export()]
//~^ ERROR malformed `macro_export` attribute input
Copy link
Contributor Author

@Periodic1911 Periodic1911 Jul 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change! Malformed macro_export attributes have had a lint since 2023 (deny(invalid_macro_export_arguments)). This PR makes this an error.
Furthermore, #[macro_export()] has been accepted since 2023, and this PR makes that an error too.

As discussed in #142838 (comment), we can make breaking changes as long as we do a crater run. So this PR needs a crater run.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 13, 2025

☔ The latest upstream changes (presumably #140717) made this pull request unmergeable. Please resolve the merge conflicts.

@jdonszelmann jdonszelmann mentioned this pull request Jul 13, 2025
Open
9 tasks
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jul 13, 2025

@Periodic1911 if you rebase I'll run a crater

@jdonszelmann jdonszelmann added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 13, 2025
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jul 13, 2025

@rust-lang/lang this makes a long-standing warning an error with a crater run. Just wanted to notify you

@traviscross traviscross added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 13, 2025
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jul 13, 2025
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jul 13, 2025

@bors try

bors added a commit that referenced this pull request Jul 13, 2025
@bors
Auto merge of #143857 - Periodic1911:macro-export, r=<try>
723ab94 
Port #[macro_export] to the new attribute parsing infrastructure

Ports macro_export to the new attribute parsing infrastructure for #131229 (comment)

r? `@oli-obk`

cc `@JonathanBrouwer` `@jdonszelmann`
@bors
Copy link
Collaborator

bors commented Jul 13, 2025

⌛ Trying commit ac1f122 with merge 723ab94...

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

☀️ Try build successful - checks-actions
Build commit: 723ab94 (723ab942d877517caf445dafde0416803ef56501)

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jul 13, 2025

@craterbot check

bors added a commit that referenced this pull request Aug 5, 2025
@bors
Auto merge of #144952 - samueltardieu:rollup-74t6irz, r=samueltardieu
3657a3d 
Rollup of 11 pull requests

Successful merges:

 - #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
 - #144133 (Stabilize const TypeId::of)
 - #144676 (Add documentation for unstable_feature_bound)
 - #144682 (Stabilize `strict_overflow_ops`)
 - #144835 (Anonymize binders in tail call sig)
 - #144836 (Change visibility of Args new function)
 - #144900 (Stabilize `unsigned_signed_diff` feature)
 - #144917 (Enforce tail call type is related to body return type in borrowck)
 - #144926 (Correct the use of `must_use` on btree::IterMut)
 - #144928 (Drop `rust-version` from `rustc_thread_pool`)
 - #144945 (Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 5, 2025
@bors
Auto merge of #144952 - samueltardieu:rollup-74t6irz, r=samueltardieu
77f529b 
Rollup of 11 pull requests

Successful merges:

 - #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
 - #144133 (Stabilize const TypeId::of)
 - #144676 (Add documentation for unstable_feature_bound)
 - #144682 (Stabilize `strict_overflow_ops`)
 - #144835 (Anonymize binders in tail call sig)
 - #144836 (Change visibility of Args new function)
 - #144900 (Stabilize `unsigned_signed_diff` feature)
 - #144917 (Enforce tail call type is related to body return type in borrowck)
 - #144926 (Correct the use of `must_use` on btree::IterMut)
 - #144928 (Drop `rust-version` from `rustc_thread_pool`)
 - #144945 (Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls`)

r? `@ghost`
`@rustbot` modify labels: rollup
@samueltardieu
Copy link
Member

samueltardieu commented Aug 5, 2025

@bors2 try jobs=test-various

This PR has been try-ed already, but it has been some weeks, and the PR has been amended and rebased since, and I'm chasing a failure identified in rollup #144952

@rust-bors
Copy link
Contributor

rust-bors bot commented Aug 5, 2025

⌛ Trying commit 23e6be2 with merge 442c572…

To cancel the try build, run the command @bors try cancel.

@rust-bors
Copy link
Contributor

rust-bors bot commented Aug 5, 2025

☀️ Try build successful (CI)
Build commit: 442c572 (442c572d1ac933be2bdaac26d263f67d954eaa4e, parent: 213d946a384b46989f6fd9c8ae9c547b4e354455)

@tgross35 tgross35 mentioned this pull request Aug 6, 2025
Closed
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Aug 6, 2025

@Periodic1911 feel free to r=me on rebase again :)

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Aug 6, 2025

@jdonszelmann It's still r+ed and in the queue atm so should not be needed right?

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Aug 6, 2025

oh my view of the comments here was severely outdated, I blame train internet.... my bad!

@tgross35 tgross35 mentioned this pull request Aug 6, 2025
Closed
This was referenced Aug 6, 2025
Closed
Closed
Merged
@bors
Copy link
Collaborator

bors commented Aug 7, 2025

☔ The latest upstream changes (presumably #145043) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Aug 8, 2025

☔ The latest upstream changes (presumably #145074) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Aug 12, 2025

☔ The latest upstream changes (presumably #145300) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2025

This PR was rebased onto a different master commit! Check out the changes with our range-diff.

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Aug 16, 2025

@rustbot review

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Sep 14, 2025

@Periodic1911 the number of attribute PRs is quite low. If you rebased I would make sure this one is guaranteed to be merged ASAP without any going before it to conflict again.

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Sep 19, 2025

@rustbot author

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer and others added 2 commits September 21, 2025 10:42
@JonathanBrouwer @Periodic1911
Port #[macro_export] to the new attribute parsing infrastructure
6abcadc 
Co-authored-by: Anne Stijns <anstijns@gmail.com>
@JonathanBrouwer @Periodic1911
Changes to uitests for macro_export port
f7fa83e 
Co-authored-by: Anne Stijns <anstijns@gmail.com>
@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Sep 21, 2025 •
edited
Loading

@rustbot ready

@jdonszelmann I rebased & did a little bit of cleanup for Anne as she didn't feel like doing it and it's nice to get this merged.

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Sep 21, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 21, 2025

📌 Commit f7fa83e has been approved by jdonszelmann

It is now in the queue for this repository.

This was referenced Sep 21, 2025
Closed
Merged
@cuviper cuviper mentioned this pull request Nov 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zalathar Zalathar Zalathar left review comments

@jdonszelmann jdonszelmann jdonszelmann requested changes

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-lang Relevant to the language team T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.