Conversation
|
|
||
| use my_api::core::{core_fn, core_fn2}; | ||
| use my_api::utils::*; | ||
| use my_api::*; |
There was a problem hiding this comment.
In the 3-scope model this would import from both my_api(crate) and my_api(open_ns).
Therefore it will introduce names root_function, core and utils into this module.
Need to test this behavior.
Old comment (based on mixing open-ns-my_api.rs and open-ns-mod-my_api.rs):
Therefore it will introduce names
utils(mod),root_functionandcoreinto this module, but notutils(crate)because it would be shadowed byutils(mod).
It would be good to actually add a test case with scenario like that.
| @@ -0,0 +1,18 @@ | |||
| // This test should fail with `utils` being defined multiple times, since open-ns-mod-my_api.rs | |||
There was a problem hiding this comment.
Hm? There's no open-ns-mod-my_api.rs in this test.
|
@eholk FYI: when a PR is ready for review, send a message containing Thank you. |
|
@JohnCSimon @eholk is still on vacation, so I address your comment. This is still waiting on a review (see #142437 (comment)). |
|
I did the re-review and marked this as waiting on author because some comments (#142437 (comment), #142437 (comment)) are still unaddressed. |
|
Failed to set assignee to
|
|
Reminder, once the PR becomes ready for a review, use |
This is just to add a few test cases of agreed upon desired behavior for this feature so that future PRs can enable them as they start passing.
I pulled these tests out of #140271.
r? @petrochenkov
cc @b-naber