Skip to content

Delegate <SocketAddr as Debug> to ByteStr#141493

Merged
bors merged 1 commit intorust-lang:masterfrom
tamird:addreskind-bytestr
Jun 14, 2025
Merged

Delegate <SocketAddr as Debug> to ByteStr#141493
bors merged 1 commit intorust-lang:masterfrom
tamird:addreskind-bytestr

Conversation

@tamird
Copy link
Contributor

@tamird tamird commented May 24, 2025 •
edited
Loading

This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.

r? @joshtriplett

@rustbot
Copy link
Collaborator

rustbot commented May 24, 2025

Failed to set assignee to joshtripplet: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 24, 2025
@joshtriplett
Copy link
Member

joshtriplett commented Jun 12, 2025

This is a great idea! Could you please add a test to the testsuite (with header constraining the test to only run on Linux) which constructs an abstract SocketAddr, renders it, and does an assert_eq! on the output?

@joshtriplett joshtriplett added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025
@tamird tamird force-pushed the addreskind-bytestr branch from 503516d to 578e36d Compare June 12, 2025 16:48
@tamird
Copy link
Contributor Author

tamird commented Jun 12, 2025

This is a great idea! Could you please add a test to the testsuite (with header constraining the test to only run on Linux) which constructs an abstract SocketAddr, renders it, and does an assert_eq! on the output?

Done, using the same input as ByteStr's own Debug test. I didn't run it locally because I use a mac :(

joshtriplett
joshtriplett reviewed Jun 12, 2025
View reviewed changes
@joshtriplett
Copy link
Member

joshtriplett commented Jun 12, 2025

Posted one other suggestion, but with that fixed and CI passing, r=me.

@joshtriplett
Copy link
Member

joshtriplett commented Jun 12, 2025

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 12, 2025

✌️ @tamird, you can now approve this pull request!

If @joshtriplett told you to "r=me" after making some further change, please make that change, then do @bors r=@joshtriplett

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tamird
Delegate <SocketAddr as Debug> to ByteStr
ded2afc 
This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.
@tamird tamird force-pushed the addreskind-bytestr branch from 7bb9de0 to ded2afc Compare June 12, 2025 23:09
@tamird
Copy link
Contributor Author

tamird commented Jun 13, 2025

@bors r=@joshtriplett

@bors
Copy link
Collaborator

bors commented Jun 13, 2025

📌 Commit ded2afc has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 14, 2025
@jhpratt
Rollup merge of rust-lang#141493 - tamird:addreskind-bytestr, r=josht…
f82e10f 
…riplett

Delegate `<SocketAddr as Debug>` to `ByteStr`

This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.

r? `@joshtriplett`
@jhpratt jhpratt mentioned this pull request Jun 14, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 14, 2025
Merged
bors added a commit that referenced this pull request Jun 14, 2025
@bors
Auto merge of #142492 - matthiaskrgr:rollup-a132ytq, r=matthiaskrgr
9822e3d 
Rollup of 9 pull requests

Successful merges:

 - #140593 (Temporary lifetime extension through tuple struct and tuple variant constructors)
 - #141399 ([rustdoc] Give more information into extracted doctest information)
 - #141493 (Delegate `<SocketAddr as Debug>` to `ByteStr`)
 - #141811 (Unimplement unsized_locals)
 - #142243 (float tests: deduplicate min, max, and rounding tests)
 - #142464 (variadic functions: remove list of supported ABIs from error)
 - #142477 (Fix incorrect suggestion when calling an associated type with a type anchor)
 - #142484 (Remove unneeded lifetime bound from signature of BTreeSet::extract_if)
 - #142489 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8f90d05 into rust-lang:master Jun 14, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 14, 2025
@tamird tamird deleted the addreskind-bytestr branch June 14, 2025 12:38
rust-timer added a commit that referenced this pull request Jun 14, 2025
@rust-timer
Unrolled build for #141493
02f5748 
Rollup merge of #141493 - tamird:addreskind-bytestr, r=joshtriplett

Delegate `<SocketAddr as Debug>` to `ByteStr`

This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.

r? ``@joshtriplett``
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142492 - matthiaskrgr:rollup-a132ytq, r=matthiaskrgr
9b89c65 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#140593 (Temporary lifetime extension through tuple struct and tuple variant constructors)
 - rust-lang/rust#141399 ([rustdoc] Give more information into extracted doctest information)
 - rust-lang/rust#141493 (Delegate `<SocketAddr as Debug>` to `ByteStr`)
 - rust-lang/rust#141811 (Unimplement unsized_locals)
 - rust-lang/rust#142243 (float tests: deduplicate min, max, and rounding tests)
 - rust-lang/rust#142464 (variadic functions: remove list of supported ABIs from error)
 - rust-lang/rust#142477 (Fix incorrect suggestion when calling an associated type with a type anchor)
 - rust-lang/rust#142484 (Remove unneeded lifetime bound from signature of BTreeSet::extract_if)
 - rust-lang/rust#142489 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 16, 2025
@bors
Auto merge of #142492 - matthiaskrgr:rollup-a132ytq, r=matthiaskrgr
39514f4 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#140593 (Temporary lifetime extension through tuple struct and tuple variant constructors)
 - rust-lang/rust#141399 ([rustdoc] Give more information into extracted doctest information)
 - rust-lang/rust#141493 (Delegate `<SocketAddr as Debug>` to `ByteStr`)
 - rust-lang/rust#141811 (Unimplement unsized_locals)
 - rust-lang/rust#142243 (float tests: deduplicate min, max, and rounding tests)
 - rust-lang/rust#142464 (variadic functions: remove list of supported ABIs from error)
 - rust-lang/rust#142477 (Fix incorrect suggestion when calling an associated type with a type anchor)
 - rust-lang/rust#142484 (Remove unneeded lifetime bound from signature of BTreeSet::extract_if)
 - rust-lang/rust#142489 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#141493 - tamird:addreskind-bytestr, r=josht…
2506df3 
…riplett

Delegate `<SocketAddr as Debug>` to `ByteStr`

This allows UTF-8 characters to be printed without escapes, rather than
just ASCII.

r? ``@joshtriplett``
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Jul 12, 2025
@bors
Auto merge of #142492 - matthiaskrgr:rollup-a132ytq, r=matthiaskrgr
8da80d7 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#140593 (Temporary lifetime extension through tuple struct and tuple variant constructors)
 - rust-lang/rust#141399 ([rustdoc] Give more information into extracted doctest information)
 - rust-lang/rust#141493 (Delegate `<SocketAddr as Debug>` to `ByteStr`)
 - rust-lang/rust#141811 (Unimplement unsized_locals)
 - rust-lang/rust#142243 (float tests: deduplicate min, max, and rounding tests)
 - rust-lang/rust#142464 (variadic functions: remove list of supported ABIs from error)
 - rust-lang/rust#142477 (Fix incorrect suggestion when calling an associated type with a type anchor)
 - rust-lang/rust#142484 (Remove unneeded lifetime bound from signature of BTreeSet::extract_if)
 - rust-lang/rust#142489 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #142492 - matthiaskrgr:rollup-a132ytq, r=matthiaskrgr
ce7404d 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#140593 (Temporary lifetime extension through tuple struct and tuple variant constructors)
 - rust-lang/rust#141399 ([rustdoc] Give more information into extracted doctest information)
 - rust-lang/rust#141493 (Delegate `<SocketAddr as Debug>` to `ByteStr`)
 - rust-lang/rust#141811 (Unimplement unsized_locals)
 - rust-lang/rust#142243 (float tests: deduplicate min, max, and rounding tests)
 - rust-lang/rust#142464 (variadic functions: remove list of supported ABIs from error)
 - rust-lang/rust#142477 (Fix incorrect suggestion when calling an associated type with a type anchor)
 - rust-lang/rust#142484 (Remove unneeded lifetime bound from signature of BTreeSet::extract_if)
 - rust-lang/rust#142489 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #142492 - matthiaskrgr:rollup-a132ytq, r=matthiaskrgr
d033b5c 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#140593 (Temporary lifetime extension through tuple struct and tuple variant constructors)
 - rust-lang/rust#141399 ([rustdoc] Give more information into extracted doctest information)
 - rust-lang/rust#141493 (Delegate `<SocketAddr as Debug>` to `ByteStr`)
 - rust-lang/rust#141811 (Unimplement unsized_locals)
 - rust-lang/rust#142243 (float tests: deduplicate min, max, and rounding tests)
 - rust-lang/rust#142464 (variadic functions: remove list of supported ABIs from error)
 - rust-lang/rust#142477 (Fix incorrect suggestion when calling an associated type with a type anchor)
 - rust-lang/rust#142484 (Remove unneeded lifetime bound from signature of BTreeSet::extract_if)
 - rust-lang/rust#142489 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
tgross35 pushed a commit to rust-lang/compiler-builtins that referenced this pull request Jan 31, 2026
@bors
Auto merge of #142492 - matthiaskrgr:rollup-a132ytq, r=matthiaskrgr
2512295 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#140593 (Temporary lifetime extension through tuple struct and tuple variant constructors)
 - rust-lang/rust#141399 ([rustdoc] Give more information into extracted doctest information)
 - rust-lang/rust#141493 (Delegate `<SocketAddr as Debug>` to `ByteStr`)
 - rust-lang/rust#141811 (Unimplement unsized_locals)
 - rust-lang/rust#142243 (float tests: deduplicate min, max, and rounding tests)
 - rust-lang/rust#142464 (variadic functions: remove list of supported ABIs from error)
 - rust-lang/rust#142477 (Fix incorrect suggestion when calling an associated type with a type anchor)
 - rust-lang/rust#142484 (Remove unneeded lifetime bound from signature of BTreeSet::extract_if)
 - rust-lang/rust#142489 (Update the `compiler-builtins` subtree)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtriplett joshtriplett joshtriplett left review comments

Assignees

@joshtriplett joshtriplett

Labels

O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tamird @rustbot @joshtriplett @bors @rust-log-analyzer