Extend minicore with intrinsics and use it to replace #[rustc_intrinsic] in tests#141319
Open
rptr wants to merge 2 commits intorust-lang:mainfrom
Open
Extend minicore with intrinsics and use it to replace #[rustc_intrinsic] in tests#141319rptr wants to merge 2 commits intorust-lang:mainfrom
rptr wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Collaborator
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
@rustbot author |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Member
bjorn3
reviewed
May 21, 2025
Comment on lines
+195
to
+199
| #[lang = "panic"] | ||
| pub fn panic(_msg: &'static str) {} | ||
|
|
||
| #[lang = "panic_const_neg_overflow"] | ||
| pub fn panic_const_neg_overflow() {} |
Member
There was a problem hiding this comment.
Shouldn't these functions return !?
Collaborator
|
☔ The latest upstream changes (presumably #137944) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@rptr |
Member
|
@rptr any updates on this? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #139918