Skip to content

Add regression test for nested replacement ranges in cfg_eval#139286

Open
reez12g wants to merge 1 commit intorust-lang:mainfrom
reez12g:add-regression-test-132727
Open

Add regression test for nested replacement ranges in cfg_eval#139286
reez12g wants to merge 1 commit intorust-lang:mainfrom
reez12g:add-regression-test-132727

Conversation

@reez12g
Copy link
Contributor

@reez12g reez12g commented Apr 2, 2025

Closes #132727

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
@reez12g
Copy link
Contributor Author

reez12g commented Apr 2, 2025

@rustbot label -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025
@reez12g
Copy link
Contributor Author

reez12g commented Apr 3, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 3, 2025
@reez12g reez12g marked this pull request as ready for review April 3, 2025 02:25
fmease
fmease reviewed May 1, 2025
View reviewed changes
tests/ui/conditional-compilation/nested-replacement-ranges-regression.rs
Copy link
Member

@fmease fmease Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just me having a very first glance at this PR and at surrounding context, I'll give this a proper review some other time:

I'm surprised that this test leads to errors (2× "removing an expression is not supported in this position") in nightly-2024-08-15 which is a few nightlies before PR #128725 (which intro'ed the ICE reported in #129166 (e.g., nightly-2024-09-08)). Shouldn't it pass in that version to be a proper regression test instead of erroring as in nightly-2024-09-09?

@apiraino
Copy link
Contributor

apiraino commented Jun 19, 2025

Based on this comment, switching to waiting on author to incorporate changes. Feel free to request a review with @rustbot ready, thanks!

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@alex-semenyuk
Copy link
Member

alex-semenyuk commented Aug 10, 2025

@reez12g
Thanks for your contribution.
Form wg-triage. Could you please take a look comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@fmease fmease

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a regression test for #132587

5 participants

@reez12g @rustbot @apiraino @alex-semenyuk @fmease