feat: add succinct-zkvm os and target#138463
Conversation
|
These commits modify compiler targets. |
succinct-zkvm os and target
|
Amended description with the std-lib pr. |
|
@jieyouxu tagging you here as I saw you did |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It is correct. I will roll a compiler lead (see https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#targets). r? compiler_leads |
|
Please also include a Platform Support page, see https://doc.rust-lang.org/rustc/target-tier-policy.html#adding-a-new-target. |
|
added thanks |
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
This comment has been minimized.
This comment has been minimized.
c7bcb1f to
f9accfb
Compare
f9accfb to
7e69cf7
Compare
|
Updated to fix tidy lint |
This comment has been minimized.
This comment has been minimized.
|
|
||
| ("riscv32i-unknown-none-elf", riscv32i_unknown_none_elf), | ||
| ("riscv32im-risc0-zkvm-elf", riscv32im_risc0_zkvm_elf), | ||
| ("riscv32im-succinct-zkvm-elf", riscv32im_succinct_zkvm_elf), |
There was a problem hiding this comment.
By putting a dash in the target OS, you make it look like it's vendor:succinct, os:zkvm. I would recommend calling it riscv32im-succinct_zkvm-elf or even just rustc32im-succinct-elf instead
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
|
UI tests should be fixed now! |
This comment has been minimized.
This comment has been minimized.
|
Bump on this :) is there discussion blocking this I should be aware of |
|
☔ The latest upstream changes (presumably #137836) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Going to reroll review for t-compiler r? compiler |
|
#t-compiler/meetings > [weekly] 2025-04-24 @ 💬 |
|
Triage: ping @wesleywiser (in the zulip thread you said you would take a look) |
|
Hi @nhtyy. I'm so sorry for the very long delay here. In #135376, the compiler team decided that we should move away from Other than that, I think the rest of this change looks ok so if you could update the target OS name to avoid |
Adds the
succinct-zkvmtarget and operating system. I will amend this descprtion with a PR to add std-lib support shortlyEDIT: std-lib PR currently maintained on my fork.
https://github.com/succinctlabs/rust-fork/pull/1/files
Tier 3 Policy:
Understood.
This PR uses existing
zkvmtarget triple style.Understood
Understood
Understood
Understood
Understood.
Understood.
Understood.
Understood, in progress.
Understood
Understood.