Compile run-make-support and run-make tests with the bootstrap compiler#137373
Compile run-make-support and run-make tests with the bootstrap compiler#137373bors merged 6 commits intorust-lang:masterfrom
Conversation
|
The run-make-support library was changed cc @jieyouxu The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol This PR modifies cc @jieyouxu This PR modifies If appropriate, please update Some changes occurred in src/tools/compiletest cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
f77af42 to
3f27d09
Compare
This comment has been minimized.
This comment has been minimized.
|
Oh wow, the run-make tests actually succeeded even with the environment variables cleaned. Wonderful! Now the hard mode - Apple and Windows. @bors try |
Compile run-make-support and run-make tests with the bootstrap compiler It does not seem necessary to have to recompile run-make-support on changes to the local compiler/stdlib. This PR simplifies the implementation of a few tools, then switches rms to stage0 and also makes the handling of environment variables in run-make tests simpler. Best reviewed commit-by-commit. I can split it into multiple PRs if you want. Based on: rust-lang#137215 r? `@jieyouxu` try-job: x86_64-apple-1 try-job: x86_64-apple-2 try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
3f27d09 to
41235fd
Compare
|
@bors try |
Compile run-make-support and run-make tests with the bootstrap compiler It does not seem necessary to have to recompile run-make-support on changes to the local compiler/stdlib. This PR simplifies the implementation of a few tools, then switches rms to stage0 and also makes the handling of environment variables in run-make tests simpler. Best reviewed commit-by-commit. I can split it into multiple PRs if you want. Based on: rust-lang#137215 r? `@jieyouxu` try-job: x86_64-apple-1 try-job: x86_64-apple-2 try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
|
☀️ Try build successful - checks-actions |
|
Incredible. |
|
@rustbot author |
|
@bors treeclosed=102 The RfL job needs to be patched due to rustup update. |
|
@bors retry |
Compile run-make-support and run-make tests with the bootstrap compiler It does not seem necessary to have to recompile run-make-support on changes to the local compiler/stdlib. This PR simplifies the implementation of a few tools, then switches rms to stage0 and also makes the handling of environment variables in run-make tests simpler. Best reviewed commit-by-commit. I can split it into multiple PRs if you want. Also tested that `COMPILETEST_FORCE_STAGE0=1 ./x test tests/run-make --stage 0` still works. Incredibly, it looks like it even passes more tests than on `master` 😆 r? `@jieyouxu`
|
What the hell bors, I said retry, not cancel-everything-and-retry-immediately... |
|
Huh, I don't think I've ever seen that. Is it that when this PR has highest p, a retry will cancel the active tested job if it's a lower p? |
|
It's possible 🤷 No idea. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
|
Sigh, more spurious shit. @bors p=0 |
|
@bors retry (spurious mingw) |
|
Huh, I think the p does matter for retry |
|
This indeed didn't break anything for cg_clif. I just needed to change some patches. In fact some of the patches were no longer necessary. I previously had to patch out usage of |
|
That's nice to hear, thanks! :) |
It does not seem necessary to have to recompile run-make-support on changes to the local compiler/stdlib. This PR simplifies the implementation of a few tools, then switches rms to stage0 and also makes the handling of environment variables in run-make tests simpler.
Best reviewed commit-by-commit. I can split it into multiple PRs if you want.
Also tested that
COMPILETEST_FORCE_STAGE0=1 ./x test tests/run-make --stage 0still works. Incredibly, it looks like it even passes more tests than onmaster😆r? @jieyouxu