const-in-pattern: test that the PartialEq impl does not need to be const#135064
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 4, 2025
Merged
Conversation
d8e53a6 to
dbf3f22
Compare
Contributor
@RalfJung: You'd probably know best where to put that? I assume it would be at the same place we check that |
Contributor
|
Anyways r=me with or without that comment |
Member
Author
|
Hm I thought there was something somewhere else, since ir was some PR of course that fixed the behavior here... |
dbf3f22 to
b806dcc
Compare
Collaborator
|
Some changes occurred in match checking cc @Nadrieril |
Member
Author
|
@bors r=compiler-errors |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133964 (core: implement `bool::select_unpredictable`) - rust-lang#135001 (Allow using self-contained LLD in bootstrap) - rust-lang#135055 (Report impl method has stricter requirements even when RPITIT inference gets in the way) - rust-lang#135064 (const-in-pattern: test that the PartialEq impl does not need to be const) - rust-lang#135066 (bootstrap: support `./x check run-make-support`) - rust-lang#135069 (remove unused function params) - rust-lang#135084 (Update carrying_mul_add test to tolerate `nuw`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2025
Rollup merge of rust-lang#135064 - RalfJung:const-in-pat-partial-eq-not-const, r=compiler-errors const-in-pattern: test that the PartialEq impl does not need to be const Fixes rust-lang#119398 by adding a test. `@compiler-errors` is there some place in the code where we could add a comment saying "as a backcompat hack, here we only require `PartialEq` and not `const PartialEq`"? r? `@compiler-errors`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119398 by adding a test.
@compiler-errors is there some place in the code where we could add a comment saying "as a backcompat hack, here we only require
PartialEqand notconst PartialEq"?r? @compiler-errors