PassWrapper: disable UseOdrIndicator for Asan Win32#132773
PassWrapper: disable UseOdrIndicator for Asan Win32#132773bors merged 1 commit intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
b9c4b61 to
1d815e5
Compare
|
Is there a test that this would affect? |
|
Thank you very much for helping me out with pushing #123617 through the last mile, @1c3t3a and @jakos-sec! It has been much appreciated. |
|
I just verified that this indeed fixes #124390. |
|
Thank you for verifying it, @1c3t3a! Much appreciated. As @workingjubilee mentioned, would you mind also adding a build-pass ui regression test for it? |
|
Yeah. It's not clear to me what this needs for testing, right now. If you need to do a somewhat baroque custom build of Rust code, we can walk you through setting that up. But this really should land with a regression test. |
1d815e5 to
592eea6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
592eea6 to
831e22a
Compare
|
We just added the ui regression test and tested it on Windows. Let me know what you think. (I forgot to rebase on the first force push, sorry if this triggered some cc's). |
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks, this LGTM with one minor nit.
831e22a to
e40481e
Compare
|
Thanks r? jieyouxu |
PassWrapper: disable UseOdrIndicator for Asan Win32 As described in https://reviews.llvm.org/D137227 UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions. Fixes rust-lang#124390. Credits also belong to `@1c3t3a` who worked with me on this. We are currently testing this on a Windows machine.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
As described here UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions (https://reviews.llvm.org/D137227). Co-Authored-By: Bastian Kersting <bkersting@google.com>
e40481e to
61013f0
Compare
|
Apparently our test infra has a bug with @bors r+ (only test changes got reverted) |
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#132010 (ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT`) - rust-lang#132310 (compiletest: add `max-llvm-major-version` directive) - rust-lang#132773 (PassWrapper: disable UseOdrIndicator for Asan Win32) - rust-lang#133013 (compiletest: known-bug / crashes: allow for an "auxiliary" directory to contain files that do not have a "known-bug" directive) - rust-lang#133027 (Fix a copy-paste issue in the NuttX raw type definition) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#132773 - jakos-sec:fix-asan-win32, r=jieyouxu PassWrapper: disable UseOdrIndicator for Asan Win32 As described in https://reviews.llvm.org/D137227 UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions. Fixes rust-lang#124390. Credits also belong to `@1c3t3a` who worked with me on this. We are currently testing this on a Windows machine.
As described in https://reviews.llvm.org/D137227 UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions.
Fixes #124390.
Credits also belong to @1c3t3a who worked with me on this.
We are currently testing this on a Windows machine.