Add illumos target documentation#132477
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 30, 2024
Merged
Conversation
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use |
This comment has been minimized.
This comment has been minimized.
jclulow
suggested changes
Nov 1, 2024
Contributor
jclulow
left a comment
There was a problem hiding this comment.
Thanks for getting this started, with my apologies for not having had a chance to do it myself!
29b8439 to
5239a2a
Compare
Member
Author
|
That took a while, I sort of forgot about this PR, but I finally addressed your feedback and it should be good to go now! |
Contributor
|
Thanks! |
jclulow
approved these changes
Dec 29, 2024
Member
|
Cool! @bors r+ rollup |
Collaborator
Contributor
|
Doesn't this need SUMMARY.md updated and links added? |
Member
|
I guess so! @bors r- |
Member
Author
|
💀 |
5239a2a to
ac3ffcc
Compare
Member
Author
|
OK, fixed it and verified that it works locally. |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 30, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#132477 (Add illumos target documentation) - rust-lang#134871 (Add codegen test for issue 63646) - rust-lang#134911 (chore: fix typos) - rust-lang#134922 (Fix typos) - rust-lang#134924 (ci: Cleanup docker build logs in CI) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 30, 2024
Rollup merge of rust-lang#132477 - Noratrieb:illumos-oxide, r=workingjubilee Add illumos target documentation Fixes rust-lang#130132 (comment) `@jclulow` `@pfmooney` I'm adding you as requested. The page is very barebones (as I do not know illumos well) and could use some improvements (for example in the "Cross-compilation toolchains and C code" section). Feel free to suggest improvements (or rewrite it from scratch) if you find something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130132 (comment)
@jclulow @pfmooney I'm adding you as requested.
The page is very barebones (as I do not know illumos well) and could use some improvements (for example in the "Cross-compilation toolchains and C code" section).
Feel free to suggest improvements (or rewrite it from scratch) if you find something.