Migrate run-make/return-non-c-like-enum to rmake.rs#127116
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 29, 2024
Merged
Migrate run-make/return-non-c-like-enum to rmake.rs#127116bors merged 1 commit intorust-lang:masterfrom
run-make/return-non-c-like-enum to rmake.rs#127116bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
jieyouxu
reviewed
Jun 29, 2024
jieyouxu
approved these changes
Jun 29, 2024
Member
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks, just one suggestion for adding a test comment, then r=me.
Member
|
You can r=me with the comment added (in general, it's great to add comments to run-make tests that try to explain at least a little bit what the test is about, or link to existing issues etc.). |
fec90fa to
a67ebc5
Compare
a67ebc5 to
8cbeeda
Compare
Member
Author
|
So I also somewhow removed the wrong file in the tidy list. So I fixed that and added the comment for what the test is about. :) |
Member
|
@bors r=Kobzol,jieyouxu |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#126805 (Migrate `pdb-alt-path`, `mismatching-target-triples` and `mingw-export-call-convention` `run-make` tests to rmake) - rust-lang#126995 (Migrate `pretty-print-with-dep-file`, `pretty-print-to-file` and `libtest-padding` `run-make` tests to rmake) - rust-lang#127041 (Migrate `run-make/override-aliased-flags` to `rmake.rs`) - rust-lang#127072 (docs: say "includes" instead of "does include") - rust-lang#127073 (Remove unnecessary SeqCst in `impl fmt::Pointer for AtomicPtr`) - rust-lang#127112 (Bootstrap: Don't get output if `lldb --version` errors) - rust-lang#127116 (Migrate `run-make/return-non-c-like-enum` to `rmake.rs`) Failed merges: - rust-lang#127050 (Make mtime of reproducible tarballs dependent on git commit) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2024
Rollup merge of rust-lang#127116 - GuillaumeGomez:run-make-return-non-c-like-enum, r=Kobzol,jieyouxu Migrate `run-make/return-non-c-like-enum` to `rmake.rs` Part of rust-lang#121876. r? `@Kobzol`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #121876.
r? @Kobzol