Merged
Conversation
Tracking issue rust-lang#99262
Collaborator
dtolnay
approved these changes
Apr 17, 2024
Member
dtolnay
left a comment
There was a problem hiding this comment.
Looks good to me, but there are at least 8 more days left in the final comment period before this can be stabilized.
Contributor
Author
|
Thanks, I didn't know that because this is my first time doing stabilisation and also didn't find it in doc or bors output. I would wait for 8 days and then ping you, once FCP is considered complete. |
5 tasks
Contributor
Author
|
@dtolnay FCP has completed now #99262 (comment) |
Member
|
@bors r+ |
Collaborator
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
Stablise io_error_downcast Tracking issue rust-lang#99262 Closes rust-lang#99262 FCP completed in rust-lang#99262 (comment)
Contributor
|
@bors retry yield to rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
…mpiler-errors Rollup of 4 pull requests Successful merges: - rust-lang#124076 (Stablise io_error_downcast) - rust-lang#124378 (Keep the LIB env var in the compiler-builtins test) - rust-lang#124379 (Remove special-casing for `SimplifiedType` for next solver) - rust-lang#124381 (Renamed `DerivedObligation` to `WellFormedDeriveObligation`) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
Rollup merge of rust-lang#124076 - NobodyXu:patch-1, r=dtolnay Stablise io_error_downcast Tracking issue rust-lang#99262 Closes rust-lang#99262 FCP completed in rust-lang#99262 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue #99262
Closes #99262
FCP completed in #99262 (comment)