Match ergonomics 2024: miscellaneous code cleanups by Jules-Bertholet · Pull Request #124047 · rust-lang/rust

Jules-Bertholet · 2024-04-16T23:13:36Z

Store ByRef instead of BindingAnnotation in PatInfo
Rename BindingAnnotation to BindingMode

@rustbot label A-patterns

rustbot · 2024-04-16T23:13:43Z

Failed to set assignee to Nadrierl: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

rustbot · 2024-04-16T23:13:45Z

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2024-04-16T23:21:01Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Nadrieril

Looks good! I can merge after you fixed the conflicts

compiler/rustc_ast/src/ast.rs

Nadrieril

@bors r+

Nadrieril · 2024-04-17T18:50:41Z

Wondered if that would work ^^

@bors r+

bors · 2024-04-17T18:50:45Z

📌 Commit ce0e27d has been approved by Nadrieril

It is now in the queue for this repository.

…leanups, r=Nadrieril Match ergonomics 2024: miscellaneous code cleanups - Store `ByRef` instead of `BindingAnnotation` in `PatInfo` - Rename `BindingAnnotation` to `BindingMode` r? `@Nadrieril` cc rust-lang#123076 `@rustbot` label A-patterns

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124041 (Fix copy path button) - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups) - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`) - rust-lang#124072 (Remove libc from more tests) - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19) - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124041 (Fix copy path button) - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups) - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`) - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19) - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#124047 - Jules-Bertholet:match-ergonomics-cleanups, r=Nadrieril Match ergonomics 2024: miscellaneous code cleanups - Store `ByRef` instead of `BindingAnnotation` in `PatInfo` - Rename `BindingAnnotation` to `BindingMode` r? ``@Nadrieril`` cc rust-lang#123076 ``@rustbot`` label A-patterns

* Update for nix Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Update to Rust 1.80.0 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Rename to BindingMode from BindingAnnotation rust-lang/rust#124047 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove TypeVariableOriginKind rust-lang/rust#123016 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove TypeVariableOrigin rust-lang/rust#124955 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove LintDiagnostic::msg rust-lang/rust#125410 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * common.rs fmt mistake indents Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * trace_in_no_trace.rs remove mistake space Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * trace_in_no_trace.rs remove mistake head space Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> --------- Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>

* Update for nix Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Update to Rust 1.80.0 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Rename to BindingMode from BindingAnnotation rust-lang/rust#124047 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove TypeVariableOriginKind rust-lang/rust#123016 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove TypeVariableOrigin rust-lang/rust#124955 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove LintDiagnostic::msg rust-lang/rust#125410 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * common.rs fmt mistake indents Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * trace_in_no_trace.rs remove mistake space Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * trace_in_no_trace.rs remove mistake head space Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Workaround for #32912 It's dirty but it worked on 2000 runs Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> --------- Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> Co-authored-by: Samson <16504129+sagudev@users.noreply.github.com>

* Update for nix Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Update to Rust 1.80.0 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Rename to BindingMode from BindingAnnotation rust-lang/rust#124047 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove TypeVariableOriginKind rust-lang/rust#123016 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove TypeVariableOrigin rust-lang/rust#124955 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Remove LintDiagnostic::msg rust-lang/rust#125410 Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * common.rs fmt mistake indents Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * trace_in_no_trace.rs remove mistake space Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * trace_in_no_trace.rs remove mistake head space Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> * Workaround for servo#32912 It's dirty but it worked on 2000 runs Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> --------- Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com> Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com> Co-authored-by: Samson <16504129+sagudev@users.noreply.github.com>

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2024

rustbot added the A-patterns Relating to patterns and pattern matching label Apr 16, 2024

rustbot assigned Nadrieril Apr 16, 2024

Jules-Bertholet force-pushed the match-ergonomics-cleanups branch from 17805f5 to 81f6d40 Compare April 16, 2024 23:20

Jules-Bertholet force-pushed the match-ergonomics-cleanups branch from 81f6d40 to c4d5134 Compare April 16, 2024 23:23

This comment has been minimized.

Sign in to view

Jules-Bertholet force-pushed the match-ergonomics-cleanups branch from c4d5134 to 053d80c Compare April 16, 2024 23:45

Nadrieril approved these changes Apr 17, 2024

View reviewed changes

compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved

compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved

Jules-Bertholet added 3 commits April 17, 2024 09:30

Store ByRef instead of BindingAnnotation in PatInfo

d19e48d

Rename BindingAnnotation to BindingMode

2a4624d

Improve BindingMode doc comment

ce0e27d

Jules-Bertholet force-pushed the match-ergonomics-cleanups branch from d930e5d to ce0e27d Compare April 17, 2024 13:35

Jules-Bertholet requested a review from Nadrieril April 17, 2024 13:35

Jules-Bertholet mentioned this pull request Apr 17, 2024

Tracking Issue for match ergonomics 2024 (RFC 3627) #123076

Open

14 tasks

Nadrieril approved these changes Apr 17, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024

matthiaskrgr mentioned this pull request Apr 18, 2024

Rollup of 6 pull requests #124109

Closed

matthiaskrgr mentioned this pull request Apr 18, 2024

Rollup of 5 pull requests #124111

Merged

bors merged commit 7add0bd into rust-lang:master Apr 18, 2024

rustbot added this to the 1.79.0 milestone Apr 18, 2024

Jules-Bertholet deleted the match-ergonomics-cleanups branch April 18, 2024 12:36

smoelius added a commit to trailofbits/dylint that referenced this pull request May 14, 2024

Account for rust-lang/rust#124047

edf6d03

smoelius added a commit to trailofbits/dylint that referenced this pull request May 14, 2024

Account for rust-lang/rust#124047

379054f

smoelius added a commit to trailofbits/dylint that referenced this pull request May 14, 2024

Account for rust-lang/rust#124047

1512e1a

github-merge-queue bot pushed a commit to trailofbits/dylint that referenced this pull request May 14, 2024

Account for rust-lang/rust#124047

909898d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Match ergonomics 2024: miscellaneous code cleanups#124047

Match ergonomics 2024: miscellaneous code cleanups#124047
bors merged 3 commits intorust-lang:masterfrom
Jules-Bertholet:match-ergonomics-cleanups

Jules-Bertholet commented Apr 16, 2024 •

edited

Loading

Uh oh!

rustbot commented Apr 16, 2024

Uh oh!

rustbot commented Apr 16, 2024

Uh oh!

rustbot commented Apr 16, 2024

Uh oh!

This comment has been minimized.

Nadrieril left a comment

Uh oh!

Uh oh!

Uh oh!

Nadrieril left a comment

Uh oh!

Nadrieril commented Apr 17, 2024

Uh oh!

bors commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Jules-Bertholet commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 16, 2024

Uh oh!

rustbot commented Apr 16, 2024

Uh oh!

rustbot commented Apr 16, 2024

Uh oh!

This comment has been minimized.

Nadrieril left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Nadrieril left a comment

Choose a reason for hiding this comment

Uh oh!

Nadrieril commented Apr 17, 2024

Uh oh!

bors commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Jules-Bertholet commented Apr 16, 2024 •

edited

Loading