Fix OutsideLoop's error suggestion: adding label 'block for if block.#123623
Merged
bors merged 1 commit intorust-lang:masterfrom May 23, 2024
Merged
Fix OutsideLoop's error suggestion: adding label 'block for if block.#123623bors merged 1 commit intorust-lang:masterfrom
'block for if block.#123623bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
This comment has been minimized.
This comment has been minimized.
estebank
reviewed
Apr 8, 2024
estebank
reviewed
Apr 10, 2024
estebank
reviewed
Apr 10, 2024
estebank
reviewed
Apr 10, 2024
estebank
reviewed
Apr 10, 2024
Contributor
estebank
left a comment
There was a problem hiding this comment.
Left some nitpicks, I need a bit more time to properly review. Thank you for taking the time to address this!
Contributor
Author
Okay, thank you very much, your review reply is very prompt, 👍 I'll fix the above problem first. |
This comment has been minimized.
This comment has been minimized.
davidtwco
requested changes
May 20, 2024
This comment has been minimized.
This comment has been minimized.
…r we wiil get another err: block label not supported here. fixes rust-lang#123261
Contributor
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122665 (Add some tests for public-private dependencies.) - rust-lang#123623 (Fix OutsideLoop's error suggestion: adding label `'block` for `if` block.) - rust-lang#125054 (Handle `ReVar` in `note_and_explain_region`) - rust-lang#125156 (Expand `for_loops_over_fallibles` lint to lint on fallibles behind references.) - rust-lang#125222 (Migrate `run-make/issue-46239` to `rmake`) - rust-lang#125316 (Tweak `Spacing` use) - rust-lang#125392 (Wrap Context.ext in AssertUnwindSafe) - rust-lang#125417 (self-contained linker: retry linking without `-fuse-ld=lld` on CCs that don't support it) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 23, 2024
Rollup merge of rust-lang#123623 - surechen:fix_123261, r=estebank Fix OutsideLoop's error suggestion: adding label `'block` for `if` block. For OutsideLoop we should not suggest add `'block` label in `if` block, or we wiil get another err: block label not supported here. fixes rust-lang#123261
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OutsideLoop we should not suggest add
'blocklabel inifblock, or we wiil get another err: block label not supported here.fixes #123261