Add hash-bangs to Python executables in src/etc

[eliovir]

No description provided.

[adrientetar]

This script is called via Makefile at: mk/tests.mk:264

[adrientetar]

Is it needed to add shebang-lines to files that are called by Makefiles?

[eliovir]

I did this change because on Gentoo one of these files is called directly and all of them are executable.
For me, executable files are called directly, without using python executable as it is it done in the Makefiles you quoted. I was not aware of their use in Makefiles as script called by python binary.

So, I think : if my changes are not useful (because it can be a change only for Gentoo overlay), executable property must be remove.

[omasanori]

hi, I did call get-snapshot.py directly in a Gentoo overlay. Latest ebuilds works without shebang, so layman -s rust will fix the problem (if you use layman to introduce gentoo-rust).

BTW, +1 to removing executable bits from those scripts. The x bit leads to confusion if the script can't call directly.

[eliovir]

Nice, overlay is already updated! Thanks @omasanori to make me aware of this.

[alexcrichton]

I think we should remove all the executable bits and make sure that the makefiles are always using CFG_PYTHON when calling these scripts.

[brson]

Do these additional suggestions for how we should deal with python scripts mean we should not add the shebangs?

[alexcrichton]

Closing due to a lack of activity, but feel free to reopen with a rebase!