Replace unsafe getuid with nix impl of Uid#116476
Closed
apekros wants to merge 1 commit intorust-lang:masterfrom
Closed
Replace unsafe getuid with nix impl of Uid#116476apekros wants to merge 1 commit intorust-lang:masterfrom
apekros wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
onur-ozkan
reviewed
Oct 9, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2023
…afe, r=clubby789 add `SAFETY` block on the usage of unsafe `getuid` We pointed out this unsafe usage in rust-lang#109859, and as a result, we received a fix PR rust-lang#116476. However, it's important to note that the `libc::getuid()` never actually fails. This PR aims to clarify its safety.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 14, 2023
…afe, r=clubby789 add `SAFETY` block on the usage of unsafe `getuid` We pointed out this unsafe usage in rust-lang#109859, and as a result, we received a fix PR rust-lang#116476. However, it's important to note that the `libc::getuid()` never actually fails. This PR aims to clarify its safety.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2023
Rollup merge of rust-lang#116577 - onur-ozkan:add-safety-block-on-unsafe, r=clubby789 add `SAFETY` block on the usage of unsafe `getuid` We pointed out this unsafe usage in rust-lang#109859, and as a result, we received a fix PR rust-lang#116476. However, it's important to note that the `libc::getuid()` never actually fails. This PR aims to clarify its safety.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #109859