treat host effect params as erased in codegen#115817
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo |
| /// Returns generic arguments that are not lifetimes. Consider using `non_erasable_generics_real` | ||
| /// if you have access to the generics declaration that this instance is for. | ||
| #[inline] | ||
| pub fn non_erasable_generics( |
There was a problem hiding this comment.
I just did a quick survey, all uses of this function have that information available, even if it requires some minor changes. Instead of passing in the generics, you could pass in the DefId to make it less verbose to use.
953cfd1 to
58c9946
Compare
This comment has been minimized.
This comment has been minimized.
58c9946 to
b4ee155
Compare
This comment has been minimized.
This comment has been minimized.
This fixes the changes brought to codegen tests when effect params are added to libcore, by not attempting to monomorphize functions that get the host param by being `const fn`.
b4ee155 to
a0a801c
Compare
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (5e71913): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.643s -> 630.976s (-0.26%) |
…-obk treat host effect params as erased in codegen This fixes the changes brought to codegen tests when effect params are added to libcore, by not attempting to monomorphize functions that get the host param by being `const fn`. r? `@oli-obk`
This fixes the changes brought to codegen tests when effect params are added to libcore, by not attempting to monomorphize functions that get the host param by being
const fn.r? @oli-obk