Don't manually compute param indices when adding implicit Sized and ConstParamHasTy#115361
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 3, 2023
Merged
Don't manually compute param indices when adding implicit Sized and ConstParamHasTy#115361bors merged 1 commit intorust-lang:masterfrom
Sized and ConstParamHasTy#115361bors merged 1 commit intorust-lang:masterfrom
Conversation
cjgillot
reviewed
Aug 31, 2023
…and ConstParamHasTy
712bcc4 to
c5d0f6c
Compare
Contributor
|
@bors r+ |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (53a0397): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.051s -> 628.237s (-0.29%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can just use resolve_bound_vars to compute these indices faithfully.
This also makes the code easier to support where clauses on
non_lifetime_binders(likewhere for<T: Debug> ..., etc, which I've got a WIP implementation of).r? @cjgillot