canonicalize in inspect, work towards intercrate_ambiguity_causes support#114810
Closed
lcnr wants to merge 8 commits intorust-lang:masterfrom
Closed
canonicalize in inspect, work towards intercrate_ambiguity_causes support#114810lcnr wants to merge 8 commits intorust-lang:masterfrom
intercrate_ambiguity_causes support#114810lcnr wants to merge 8 commits intorust-lang:masterfrom
Conversation
the unnormalized goal is in the callers inference context, while anything inside of the `CanonicalGoalEvaluation` is inside of a new one.
This comment has been minimized.
This comment has been minimized.
lcnr
commented
Aug 14, 2023
Contributor
Author
lcnr
left a comment
There was a problem hiding this comment.
this code needs a lot of comments
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #114023) made this pull request unmergeable. Please resolve the merge conflicts. |
add `TraitCandidate` variant using `CandidateSource`
Contributor
|
@rustbot author |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2023
some inspect improvements split from rust-lang#114810 because I still want to experiment a bunch with that PR and these changes are self-contained. r? `@compiler-errors`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we can now do stuff with the state of nested goals as it does not contain anything local to the inference context inside of the query: https://hackmd.io/57Viy5smRNykmMVB6O76EA.
To actually add
intercrate_ambiguity_causessupport I need to figure out an API to traverse proof trees. Doing so manually for each analysis will be annoying. Still unsure what's the best approach here and have to think more about this.The last commit is the layout of how
intercrate_ambiguity_causescan be supported, still have to implement the actual computation of them thoughr? @compiler-errors