Split marking and visit to compute live_symbols.

[cjgillot]

r? @ghost

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit d19e6875e769e9b663c9d996a5266e10e46bc160 with merge 231164975edec27cf8178ffff8e54c4ccc4a0ef8...

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 068b0ff with merge c44ac17ab5a67f3d799a00f745b19bd776efa3d5...

[rust-log-analyzer]

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] tool::ToolBuild { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu, tool: "opt-dist", path: "src/tools/opt-dist", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [], allow_features: "" } -- 23.334
[TIMING] tool::OptimizedDist { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu }, target: x86_64-unknown-linux-gnu } -- 0.000
Build completed successfully in 0:00:23
+ ./build/x86_64-unknown-linux-gnu/stage0-tools-bin/opt-dist python3 ../x.py dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu --include-default-paths build-manifest bootstrap
[2023-08-06T11:04:27.533Z INFO  opt_dist] Skipping building of unimportant components for a try build
[2023-08-06T11:04:27.533Z INFO  opt_dist::utils::io] Resetting directory /tmp/tmp-multistage/opt-artifacts
##[group]Environment values
Environment values
HOSTNAME=7dca771de40a
---
[RUSTC-TIMING] rustc_plugin_impl test:false 2.786
   Compiling rustc_passes v0.0.0 (/checkout/compiler/rustc_passes)
   Compiling rustc_mir_build v0.0.0 (/checkout/compiler/rustc_mir_build)
[RUSTC-TIMING] rustc_privacy test:false 7.984
error[E0599]: no method named `live_symbols_and_ignored_derived_traits_from` found for struct `TyCtxt<'_>` in the current scope
    |
    |
666 |         let reachable = tcx.live_symbols_and_ignored_derived_traits_from(id);
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: there is a method with a similar name: `live_symbols_and_ignored_derived_traits`
For more information about this error, try `rustc --explain E0599`.
[RUSTC-TIMING] rustc_passes test:false 2.595
error: could not compile `rustc_passes` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
---
Caused by:
    Command RUST_BACKTRACE=full python3 /checkout/x.py build --target x86_64-unknown-linux-gnu --host x86_64-unknown-linux-gnu --stage 2 library/std --rust-profile-generate /tmp/tmp-multistage/opt-artifacts/rustc-pgo --set llvm.thin-lto=false --set llvm.link-shared=true [at /checkout/obj] has failed with exit code Some(1)

Stack backtrace:
   0: <opt_dist::exec::CmdBuilder>::run
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/exec.rs:78:17
   1: <opt_dist::exec::Bootstrap>::run
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/exec.rs:174:9
   2: opt_dist::execute_pipeline::{closure#1}::{closure#0}
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/main.rs:56:13
      <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}::{closure#0}, ()>
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/timer.rs:111:22
      opt_dist::execute_pipeline::{closure#1}
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/main.rs:45:9
      <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}, opt_dist::training::RustcPGOProfile>
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/timer.rs:111:22
   3: opt_dist::execute_pipeline
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/main.rs:42:29
             at /rustc/231164975edec27cf8178ffff8e54c4ccc4a0ef8/src/tools/opt-dist/src/main.rs:207:18
   4: <fn() -> core::result::Result<(), anyhow::Error> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/core/src/ops/function.rs:250:5
             at /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/core/src/ops/function.rs:250:5
      std::sys_common::backtrace::__rust_begin_short_backtrace::<fn() -> core::result::Result<(), anyhow::Error>, core::result::Result<(), anyhow::Error>>
   5: std::rt::lang_start::<core::result::Result<(), anyhow::Error>>::{closure#0}
             at /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/std/src/rt.rs:166:18
             at /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/std/src/rt.rs:166:18
   6: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
      std::panicking::try::do_call
             at /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/std/src/panicking.rs:500:40
      std::panicking::try
             at /rustc/7ba605cd90d6467bda469d1cd2148ac32ea562bf/library/std/src/panicking.rs:464:19

[rust-log-analyzer]

The job x86_64-gnu-llvm-15 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=cjgillot
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_9cbfd4e2-36d6-465e-a71a-cf820127205c
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=e49389b20c2d64d910774832c45aa6bbd0a9e24f
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_9cbfd4e2-36d6-465e-a71a-cf820127205c
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_9cbfd4e2-36d6-465e-a71a-cf820127205c
GITHUB_TRIGGERING_ACTOR=cjgillot
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/114538/merge
GITHUB_WORKFLOW_SHA=e49389b20c2d64d910774832c45aa6bbd0a9e24f
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_18_X64=/opt/hostedtoolcache/go/1.18.10/x64
---
failures:

---- [incremental] tests/incremental/change_private_fn/struct_point.rs stdout ----

error in revision `cfail2`: test compilation failed although it shouldn't!
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/incremental/change_private_fn/struct_point.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-O" "--error-format" "json" "--json" "future-incompat" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point/auxiliary" "-Z" "query-dep-graph"
--- stderr -------------------------------
--- stderr -------------------------------
error: `typeck(fn_calls_methods_in_same_impl::check)` should have been loaded from disk but it was not
Build completed unsuccessfully in 0:11:25
   |
LL |     pub fn check() {
   |     ^^^^^^^^^^^^^^

[bors]

☀️ Try build successful - checks-actions
Build commit: c44ac17ab5a67f3d799a00f745b19bd776efa3d5 (c44ac17ab5a67f3d799a00f745b19bd776efa3d5)

[rust-timer]

Finished benchmarking commit (c44ac17ab5a67f3d799a00f745b19bd776efa3d5): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.4%, 1.9%]	33
Regressions ❌ (secondary)	1.8%	[0.3%, 4.5%]	33
Improvements ✅ (primary)	-2.0%	[-3.7%, -0.6%]	5
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	0.8%	[-3.7%, 1.9%]	38

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[0.9%, 6.1%]	10
Regressions ❌ (secondary)	1.5%	[1.3%, 1.6%]	4
Improvements ✅ (primary)	-1.2%	[-1.7%, -0.8%]	3
Improvements ✅ (secondary)	-2.5%	[-3.9%, -1.7%]	4
All ❌✅ (primary)	1.5%	[-1.7%, 6.1%]	13

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.1%, 4.6%]	10
Regressions ❌ (secondary)	3.5%	[2.2%, 5.0%]	13
Improvements ✅ (primary)	-2.6%	[-3.0%, -2.1%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.6%	[-3.0%, 4.6%]	13

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.941s -> 651.993s (0.32%)