Port PGO/LTO/BOLT optimized build pipeline to Rust#112235
Port PGO/LTO/BOLT optimized build pipeline to Rust#112235bors merged 1 commit intorust-lang:masterfrom
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors try |
|
⌛ Trying commit 408578eea211c890c45c32baa3983dc1abd64776 with merge da5b8ab81a6270a5a4e49c3725bfde81a7faf6a7... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
@bors try |
|
⌛ Trying commit 21c5a4f1533a34c1611ab68d1a835b1c8f3f8284 with merge 3babef129a16a88b15d4852eb488c50661b97be2... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
@bors try |
|
⌛ Trying commit e81b1be849ddf3974e4b374fc2ced4b1fabf0562 with merge 53b17b880d3f17a78cd8ee30eb7833c2e27abe3e... |
|
@bors try |
|
⌛ Trying commit 256ef913bfa09454a0644322f434f2cf3ffdec13 with merge 5ad9065b98fa007c9dd5ac8e5bce67eeccbcef6b... |
This comment was marked as outdated.
This comment was marked as outdated.
|
☀️ Try build successful - checks-actions |
|
I decided to implement support for Windows in this PR, and also remove the old Python script, to make this PR "atomic". Both Linux and Windows CI has passed, along with all the dist tests. I'll now run a perf run just to make sure that perf. is still OK. I removed PGO training on @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
|
⌛ Trying commit afe26d37b87c2d491f2f04305569c89cfffb6730 with merge 7ad6e315ce5f70086a83e4a57150a941cb42f78b... |
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (7ad6e315ce5f70086a83e4a57150a941cb42f78b): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 661.138s -> 661.963s (0.12%) |
|
@rustbot ready |
|
r=me with this rebased |
|
@bors r=Mark-Simulacrum |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (1861088): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 655.641s -> 658.609s (0.45%) |
|
This looks to me like the #113485 (comment) noise returning to steady state. |
|
This is really awesome work @Kobzol! 💯 |
This PR ports the
stage-build.pyPGO/LTO/BOLT optimization script from Python to Rust, to make it easier to use dependencies, and make it a bit more robust. The PR switches both the Linux and Windows dist runners to the Rust script and removes the old Python script.Funnily enough, the Rust port has less lines of code than the Python script :) I think that clearly shows that the Python script really lacked dependencies.