Emit warnings on unused parens in index expressions#107539
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 3, 2023
Merged
Emit warnings on unused parens in index expressions#107539bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon. Please see the contribution instructions for more information. |
lcnr
reviewed
Feb 1, 2023
8f0a139 to
06f6a77
Compare
Contributor
Author
Done. @rustbot ready |
lcnr
reviewed
Feb 2, 2023
Contributor
|
after the last nit, you can approve this pr yourself using @bors delegate+ |
Collaborator
|
📌 Commit 06f6a776c4afd36fa3bc94ccd81e9dcc1072a901 has been approved by It is now in the queue for this repository. |
Contributor
06f6a77 to
c3a71ed
Compare
Contributor
Author
|
Added the extra test. Thanks for the review! @bors r=lcnr rollup |
Collaborator
|
@PossiblyAShrub: 🔑 Insufficient privileges: Not in reviewers |
Collaborator
|
@PossiblyAShrub: 🔑 Insufficient privileges: not in try users |
Contributor
Author
|
Hmmm. Looks like bors doesn't want to let merge this. I'll just mark it as S-waiting-on-review. (Let me know if I should do something different as I am still new to the contribution process.) @rustbot ready |
Contributor
|
weird, not sure why the @bors r+ rollup thanks |
Collaborator
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 3, 2023
…dex, r=lcnr Emit warnings on unused parens in index expressions Fixes: rust-lang#96606. I am not sure what the best term for "index expression" is. Is there a better term we could use?
This was referenced Feb 3, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#107082 (Autotrait bounds on dyn-safe trait methods) - rust-lang#107427 (Add candidates for DiscriminantKind builtin) - rust-lang#107539 (Emit warnings on unused parens in index expressions) - rust-lang#107544 (Improve `TokenCursor`.) - rust-lang#107585 (Don't cause a cycle when formatting query description that references a FnDef) - rust-lang#107633 (Fix suggestion for coercing Option<&String> to Option<&str>) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #96606.
I am not sure what the best term for "index expression" is. Is there a better term we could use?