Merged
Conversation
The provided example to the `sign_plus` method on `fmt` is broken, it displays the `-` sign twice for negative numbers.
which verifies that a constant bit width is within 64 bits or fails.
…-ou-se Restore old behaviour on broken UNC paths This fixes rust-lang#101358 by restoring the behaviour from previous stable Rust versions. I'm not convinced this is ultimately right but I think it's less wrong and maybe this should be backported to beta? r? libs
…h-to-ref-to-array, r=oli-obk Suggest adding array lengths to references to arrays if possible ref: rust-lang#100590 (review)
Fix the example code and doctest for Formatter::sign_plus The provided example to the `sign_plus` method on `fmt` was broken, it displays the `-` sign twice for negative numbers. This pull request should fix the issue by `.abs()` ing the number so that the negative sign appears only once. It is just one possible solution to the issue, not sure if it's the best. However, this one will behave as expected when combined with fill and alignment operators.
update `ParamKindOrd` rust-lang#90207 (comment) 😁 writing comments "for future prs" sure works well :3 r? `@BoxyUwU`
Fix code generation of `Rvalue::Repeat` with 128 bit values Closes rust-lang#101585.
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (395e56f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ParamKindOrd#101573 (updateParamKindOrd)Rvalue::Repeatwith 128 bit values #101612 (Fix code generation ofRvalue::Repeatwith 128 bit values)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup