Skip to content

Add convert unwrap_or_else for convert_bool_then#20508

Open
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
A4-Tacks:conv-unwrap_or_else-bool-then
Open

Add convert unwrap_or_else for convert_bool_then#20508
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
A4-Tacks:conv-unwrap_or_else-bool-then

Conversation

@A4-Tacks
Copy link
Member

Example

//- minicore:bool_impl
fn main() {
    true.t$0hen(|| 3).unwrap_or_else(|| 4)
}

Old output:

//- minicore:bool_impl
fn main() {
    if true {
        Some(3)
    } else {
        None
    }.unwrap_or_else(|| 4)
}

This PR current output:

//- minicore:bool_impl
fn main() {
    if true {
        3
    } else {
        4
    }
}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2025
@A4-Tacks A4-Tacks mentioned this pull request Nov 19, 2025
41 tasks
Example
---
```rust
//- minicore:bool_impl
fn main() {
    true.t$0hen(|| 3).unwrap_or_else(|| 4)
}
```

Old output:

```rust
//- minicore:bool_impl
fn main() {
    if true {
        Some(3)
    } else {
        None
    }.unwrap_or_else(|| 4)
}
```

This PR current output:

```rust
//- minicore:bool_impl
fn main() {
    if true {
        3
    } else {
        4
    }
}
```
@A4-Tacks A4-Tacks force-pushed the conv-unwrap_or_else-bool-then branch from 40e9a20 to e2df995 Compare March 4, 2026 08:06
@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants