Limit macOS $INODE64 symbol names to x86 and x86_64#1817
Merged
JohnTitor merged 1 commit intorust-lang:masterfrom Jul 8, 2020
Merged
Limit macOS $INODE64 symbol names to x86 and x86_64#1817JohnTitor merged 1 commit intorust-lang:masterfrom
$INODE64 symbol names to x86 and x86_64#1817JohnTitor merged 1 commit intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Member
|
r=me once the style issue that CI reported is fixed. |
The new ARM-based platform doesn't need these as there's no legacy
constraints.
Tested via
**demo.c**
```c
int main() {
fstat(0, NULL);
fstatat(0, NULL, NULL, 0);
lstat(NULL, NULL);
stat(NULL, NULL);
readdir(NULL);
readdir_r(NULL, NULL, NULL);
}
```
**Compilation**
```none
% SDKROOT=/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk MACOSX_DEPLOYMENT_TARGET=11.5 cc -arch arm64 demo.c
% nm a.out
0000000100008030 d __dyld_private
0000000100000000 T __mh_execute_header
U _fstat
U _fstatat
U _lstat
0000000100003e64 T _main
U _readdir
U _readdir_r
U _stat
U dyld_stub_binder
```
This has also been experimentally compiled on a Developer Transition Kit.
31 tasks
Member
Author
Addressed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new ARM-based platform doesn't need these as there's no legacy
constraints.
Tested via
demo.c
Compilation
This has also been experimentally compiled on a Developer Transition Kit.