Add 128-bit SIMD implementation for LoongArch#592
Merged
Amanieu merged 1 commit intorust-lang:masterfrom Dec 19, 2024
heiher:loong-lsx
Merged
Add 128-bit SIMD implementation for LoongArch#592Amanieu merged 1 commit intorust-lang:masterfrom heiher:loong-lsx
Amanieu merged 1 commit intorust-lang:masterfrom
heiher:loong-lsx
Conversation
Contributor
Author
BenchmarksGenericLSX |
Amanieu
reviewed
Nov 29, 2024
src/control/group/lsx.rs
Outdated
| /// Returns a `BitMask` indicating all tags in the group which are full. | ||
| #[inline] | ||
| pub(crate) fn match_full(&self) -> BitMask { | ||
| self.match_empty_or_deleted().invert() |
Member
There was a problem hiding this comment.
Would it be faster to use lsx_vmskgez_b here?
Contributor
Author
There was a problem hiding this comment.
Yes, it would definitely be faster to use lsx_vmskgez_b here. Good catch!
Contributor
Author
|
Blocked by rust-lang/rust#133249 |
Amanieu
reviewed
Nov 29, 2024
| } else if #[cfg(all( | ||
| target_arch = "loongarch64", | ||
| target_feature = "lsx", | ||
| not(miri), |
Member
There was a problem hiding this comment.
This should be under the "nightly" feature until loongarch intrinsics are stabilized.
Contributor
There was a problem hiding this comment.
I was also going to mention this-- that way loongarch still works on stable. Although it would also be nice to have a new release so this can be used for the libstd implementation.
clarfonthey
reviewed
Dec 7, 2024
Comment on lines
+33
to
+44
| pub(crate) const fn static_empty() -> &'static [Tag; Group::WIDTH] { | ||
| #[repr(C)] | ||
| struct AlignedTags { | ||
| _align: [Group; 0], | ||
| tags: [Tag; Group::WIDTH], | ||
| } | ||
| const ALIGNED_TAGS: AlignedTags = AlignedTags { | ||
| _align: [], | ||
| tags: [Tag::EMPTY; Group::WIDTH], | ||
| }; | ||
| &ALIGNED_TAGS.tags | ||
| } |
Contributor
There was a problem hiding this comment.
Depending on the outcome of #596 you may want to add that change here as well.
Contributor
|
☔ The latest upstream changes (presumably #597) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
CI is green now. |
Amanieu
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.