Closed
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
Idk, I quite like that explicitness but maybe we should restrict it to just adding the Cargo.toml when errors are mentioned. |
Member
|
See also #7548 and rust-lang/rls#1581 . |
Contributor
Author
|
Thanks going to give the full monty a crack: #9752 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have lots of rust we have lots of crates; getting to the right cargo toml file can be tricky.
If the full path to the Cargo.toml is in the output then IDEs like vscode can just click through to go to the file in question.
This is a prelude to what I really want: I want to be able to click on an error and go to a specific line number.
At least this way we can quickly get to the specific file if not the exact line that a dependency was defined at.