ci: exclude semver check for cargo against referenced commit#13826
Closed
weihanglo wants to merge 1 commit intorust-lang:masterfrom
Closed
ci: exclude semver check for cargo against referenced commit#13826weihanglo wants to merge 1 commit intorust-lang:masterfrom
cargo against referenced commit#13826weihanglo wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
We always bump major versions for `cargo` package, so the risk of shipping breaking change should be zero. We still verify against crates.io as a sanity check.
a6cfdd6 to
cee99d3
Compare
Member
Author
|
Close in favor of #13827. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
We always bump major versions for
cargopackage,so the risk of shipping breaking change should be zero.
We still verify against crates.io as a sanity check.
How should we test and review this PR?
Check if CI is all green.
Additional information
See also https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/What.20is.20the.20reason.20for.20this.20error.3F/near/436053158