test: Make edition explicit in packages#13504
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 29, 2024
Merged
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use r? to explicitly pick a reviewer |
weihanglo
approved these changes
Feb 29, 2024
Member
weihanglo
left a comment
There was a problem hiding this comment.
Thought you implemented inline snapshot in snapbox for this PR, but it turns out that you're the inline snapshotter!
I can imagine when Edition 2024 becomes the default, we'll need to update all cargo new/init snapshots again.
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Mar 1, 2024
feat(toml): Warn on unset Edition ### What does this PR try to resolve? On [Internals](https://internals.rust-lang.org/t/idea-rustc-cargo-should-warn-on-unspecified-edition/20309), the idea came up for warning on unset Edition. Besides helping people who forget to set the Edition, this creates symmetry between `Cargo.toml` and cargo scripts (#12207). While the default is different in each case, we are making the default obvious and guiding people away from it. ### How should we test and review this PR? There are separate commits for adding tests (and refactors) so the changes in behavior will be more obvious ### Additional information This builds on - #13499 - #13504
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 2, 2024
Update cargo 12 commits in 8964c8ccff6e420e2a38b8696d178d69fab84d9d..f772ec0224d3755ce52ac5128a80319fb2eb45d0 2024-02-27 19:22:46 +0000 to 2024-03-01 22:57:35 +0000 - feat(toml): Warn on unset Edition (rust-lang/cargo#13505) - fix(msrv): Report all incompatible packages, not just a random one (rust-lang/cargo#13514) - refactor: abstract `std::fs` away from on-disk index cache (rust-lang/cargo#13515) - chore(deps): update compatible (rust-lang/cargo#13507) - chore(deps): update rust crate rusqlite to 0.31.0 (rust-lang/cargo#13510) - [docs]: Clarify vendored sources as read-only and way to modify (rust-lang/cargo#13512) - chore(deps): update rust crate supports-hyperlinks to v3 (rust-lang/cargo#13511) - refactor: Clarify more Config -> Context (rust-lang/cargo#13506) - test: Make `edition` explicit in packages (rust-lang/cargo#13504) - Add all unit's children recursively for `doc.extern-map` option (rust-lang/cargo#13481) - fix(rustc): Always pass --edition to rustc (rust-lang/cargo#13499) - Silently ignore `cargo::rustc-check-cfg` to avoid MSRV annoyance when stabilizing `-Zcheck-cfg` (rust-lang/cargo#13438) r? ghost
dieterplex
added a commit
to dieterplex/cargo
that referenced
this pull request
Jul 5, 2024
This is a follow up to 14646e6 and it would fix warnings while migrating jobserver tests to snapbox. see [feat(toml): Warn on unset Edition rust-lang#13505](rust-lang#13504)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This ensures we don't rely on the edition default for manifests, unblocking the door for warning on unset editions.
How should we test and review this PR?
Additional information
Alternatives considered
Risks