Skip to content

Handle nested timeout calls with the same duration #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
eregon wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Handle nested timeout calls with the same duration #91

eregon wants to merge 1 commit into from

Conversation

@eregon
Copy link
Member

@eregon eregon commented Dec 22, 2025

  • Prevent concurrent Thread#raise calls by tracking interruptible and interrupting states, and waiting if there is already an ongoing interrupt that we reach Request#finished.

@eregon eregon mentioned this pull request Dec 22, 2025
Open
@eregon eregon changed the title WIP: Handle nested timeouts call with same duration Handle nested timeout calls with the same duration Dec 22, 2025
@eregon
Handle nested timeouts with the same duration
789391a 
* Prevent concurrent Thread#raise calls by tracking
  interruptible and interrupting states, and waiting
  if there is already an ongoing interrupt that we reach
  Request#finished.
@eregon
Copy link
Member Author

eregon commented Dec 22, 2025

Note: maybe we should wait longer than Request#finished, e.g. to cover Error.handle_timeout logic too? Not sure it matters, if that gets interrupted by Thread#raise it seems fine enough, the current exception will be lost anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eregon