Update Ruby versions on GHA with ci_versions/all.json #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/test.yml
Outdated
| steps: | ||
| - id: versions | ||
| run: | | ||
| versions=$(curl -s 'https://cache.ruby-lang.org/pub/misc/ci_versions/cruby.json' | jq -c '. + ["2.4"]') |
Contributor
There was a problem hiding this comment.
2.5, 2.6 are not in this set, should they be?
Member
Author
There was a problem hiding this comment.
I added only the minimum supported version that is "2.4" because I needed to add "2.7" into this line when Ruby 2.7 was EOL.
I'm not sure what the best way to auto-versioning with this strategy.
Contributor
There was a problem hiding this comment.
I don't know either, but the tests run quickly, and perhaps there's added feedback to found in the 2.5, 2.6 test runs? Well, it's up to you.
Member
Author
There was a problem hiding this comment.
There is no strong opinion that. I added them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.