Repository navigation
Initialize error data using constructors directly - #2165
Merged
dblock merged 1 commit intoMar 6, 2021
Merged
Conversation
Here's an example of a CHANGELOG.md entry: * [#2165](https://github.com/ruby-grape/grape/pull/2165): Initialize error data using constructors directly - [@bjfish](https://github.com/bjfish).Generated by 🚫 Danger |
Member
|
Anything changes for users that may be relying on this that deserves a CHANGELOG/README/UPGRADING? |
eregon
reviewed
Mar 6, 2021
eregon
left a comment
Contributor
There was a problem hiding this comment.
This look good to me. It should work exactly the same or better, no user visible changes (except maybe slightly faster to build those exceptions).
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids using the
Kernel#raisestring message parameter to initialize custom data for errors in favor of initializing with the data directly as described here:#2164 (comment)
This is also consistent with other usages like:
grape/lib/grape/middleware/versioner.rb
Line 29 in e0f412c
grape/lib/grape/endpoint.rb
Line 129 in e0f412c