Repository navigation
Add Truffleruby head to CI - #2099
Conversation
|
I am open to including this into the set of builds that allow failures if someone (you?) wants to help out with truffleruby-related issues. We haven't had much success in the past with anyone caring about things like rbx. |
|
@eregon I filled out an issue , but I am not sure when it's going to be fixed. Since tests itself are passing prb I can mark it as allow failures for now |
|
One potential workaround is to run RuboCop only on MRI, it seems redundant to run it on TruffleRuby anyway. Line 27 in 7e95ac8 Otherwise the error should be solved by rubocop/rubocop#8602, and then we need to wait the next RuboCop release and make sure it's used by this repo. |
|
I would take a change to run RuboCop once for the entire suite. |
|
OK, then the easiest way to do that is to remove it as a dependency of the Rakefile default task, and to add an extra |
|
@eregon yep, will do this |
|
@dblock now I run rubocop once and truffleruby tests are green |
|
|
@dblock sure, but I am not really familiar with travis yml syntax, if you have an example it would be great. Regarding allow_failures - I can add it |
| - bundle exec danger | ||
| - rvm: 2.7.1 | ||
| script: | ||
| - rubocop |
There was a problem hiding this comment.
This should be bundle exec rubocop to pin to the version in Gemfile.
I think you can do it once at top level and the other |
|
@dblock addressed your comments |
dblock
left a comment
There was a problem hiding this comment.
Add to CHANGELOG "Added truffleruby to Travis-CI"
| gemfile: gemfiles/multi_json.gemfile | ||
| script: | ||
| - bundle exec rake | ||
| - bundle exec rubocop |
There was a problem hiding this comment.
This line should be removed and default to rake spec, we're running all the usual tests, not rubocop.
| gemfile: gemfiles/multi_xml.gemfile | ||
| script: | ||
| - bundle exec rake | ||
| - bundle exec rubocop |
|
@dblock done |
|
Merged, thanks for this. |
No description provided.