Conversation
Contributor
Author
|
I have code to help track down the memory leak using memtools, but for some reason, inspecting some of the objects results in a segfault. |
Contributor
Author
|
After poking at this some more, I believe that the cause of the memory leak is a bug in cpp11: r-lib/cpp11#154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches from Rcpp to cpp11. It might make it possible to build the package on memory-limited systems such as rstudio.cloud.
There's still one issue: the GC tests aren't passing. I tested a bit, and found that if the test block is run again, the objects from the previous run would get GC'd, but I haven't yet figured out why that is.