Merged
Conversation
alandipert
reviewed
Jul 25, 2019
cpsievert
reviewed
Jul 26, 2019
cpsievert
reviewed
Jul 26, 2019
cpsievert
reviewed
Jul 26, 2019
cpsievert
reviewed
Jul 26, 2019
Contributor
|
Code looks ✨ , thank you. Would you please also update testing notes in the PR and add a bullet to NEWS.md? I bumped the version on master to 1.1.0.9001 and made a heading under which you may add said bullet. Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
Testing Notes
1. Try out really small maximums
This is intended to be run interactively! Running in a script will likely try to send before the connection is actually open.
When you try to send/receive the message
AAAA, you should get an error because the maximum size is 2 bytes.2. Try out really large maximums
Start up a local websocket server so you can send really large messages successfully: https://github.com/rstudio/websocket/blob/master/tmp/websocketServer.R This will start a server on port 8080.
This is intended to be run interactively! Running in a script will likely try to send before the connection is actually open.
When you try to send 40 million
As, With the default maximum of 32MB, it should fail because it's too big. Once you up the max size to 50MB, you should then be able to send and receive such large messages. (This use case more accurately resembles the actual motivation for this work.)