New attribute property keywords 1822 #1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanlove
commented
Aug 12, 2023
emanlove
commented
Aug 12, 2023
emanlove
commented
Aug 12, 2023
emanlove
commented
Aug 12, 2023
yuriverweij
reviewed
Aug 29, 2023
Member
yuriverweij
left a comment
There was a problem hiding this comment.
Looks good to me. I've added a few comments.
yuriverweij
reviewed
Nov 2, 2023
This reverts commit 4a1f413.
Using prefilled value on an input element, first verify that the value attribute and property are the same. Then modifying the value by inputting text verify the value property has changed but the attribute value remains the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Get DOM AttributeandGet Propertykeywords and several acceptance tests. I know these test can be cleaned up a bit. One bit of review I am looking for is whether all the tests are there? Or if there might be something missing? I also added some comments within the tests. One issue I have been coming across is that when I go into an internal test (either acceptance or unit) some of them I have a tough time trying to see exactly what is is testing, and what should I expect it to do and verify. So I started to play around a bit with comments. I don't think there that great and need improvement. But this starts to highlight one idea for explaining tests better.