Repository navigation
chore(pi): require RivetKit 2.3.26 - #350
Draft
eersnington wants to merge 1 commit into
Draft
eersnington wants to merge 1 commit into
eersnington wants to merge 1 commit into
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require RivetKit 2.3.26, which includes the sleep fixes in rivet-dev/rivet#5835 and rivet-dev/rivet#5836.
packages/pi:rivetkitdev dependency2.3.23→2.3.26, peer range>=2.3.26 <2.4.0.examples/docs:rivetkitand@rivetkit/react2.3.23→2.3.26.2.3.26 turns off WebSocket hibernation by default, so sleep now closes client connections. A Pi watch ends when the actor sleeps, and the client watches again when its connection opens:
watchEventsagaintests/watch.test.ts: the test that expected a connection to survive sleep now covers the reconnect pattern above.tests/actor.test.ts: covers watch reattach when Pi Durable reopens after a failed commit. The removed sleep test was its only coverage.This is part 1 of 2 in a stack: