Skip to content

bump: version to 1.1.0 and support SQLAlchemy 2.0 - #29

Merged
jetjinser merged 1 commit into
mainfrom
jinser/up-v2
Apr 2, 2024
Merged

jetjinser merged 1 commit into
mainfrom
jinser/up-v2

Conversation

@jetjinser

Copy link
Copy Markdown
Contributor

No description provided.

@chenzl25

chenzl25 commented Apr 1, 2024 •

Copy link
Copy Markdown
Contributor

NOTE
When creating tables using SQLAlchemy 2.0, BIGINT types will automatically be converted to BIGSERIAL types, which is not supported in RisingWave.

There is a known issue in our document website https://docs.risingwave.com/docs/current/python-client-libraries/ .
Could you please check it for this PR?

@jetjinser

jetjinser commented Apr 1, 2024 •

Copy link
Copy Markdown
Contributor Author

NOTE
When creating tables using SQLAlchemy 2.0, BIGINT types will automatically be converted to BIGSERIAL types, which is not supported in RisingWave.

There is a known issue in our document website https://docs.risingwave.com/docs/current/python-client-libraries/ . Could you please check it for this PR?

No, it has no problem now.
The test code I'm using is:

create_table = DDL("CREATE TABLE t (bi BIGINT)")
with cnx.connect() as conn:
    conn.execute(create_table)

print(pd.read_sql_table("t", cnx))

It can be observed in the log of RisingWave that the type of bi is still BIGINT.

@chenzl25 chenzl25 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzl25
chenzl25 requested a review from neverchanje April 2, 2024 06:36
@chenzl25

chenzl25 commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

@neverchanje , the documentation of SQL Alchemy seems out of date, do you have any context about the compatibilities issue of SQL Alchemy 1.4?

@neverchanje

Copy link
Copy Markdown

I will update it once this new version gets released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants