feat(expr): support trim_array - #9265
Merged
Merged
Conversation
st1page
reviewed
Apr 19, 2023
st1page
left a comment
Contributor
There was a problem hiding this comment.
Generally LGTM.
Btw, should we support visibility bitmap in the Array(List) Type? I am not sure about there use case and workload 🤔
Codecov Report
@@ Coverage Diff @@
## main #9265 +/- ##
==========================================
- Coverage 70.80% 70.79% -0.02%
==========================================
Files 1216 1217 +1
Lines 202303 202333 +30
==========================================
Hits 143246 143246
- Misses 59057 59087 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangjinwu
reviewed
Apr 19, 2023
xiangjinwu
approved these changes
Apr 20, 2023
Honeta
enabled auto-merge
April 20, 2023 03:38
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
trim_array ( array anyarray, n integer ) → anyarray
Trims an array by removing the last n elements. If the array is multidimensional, only the first dimension is trimmed.
close #9264
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
https://www.postgresql.org/docs/current/functions-array.html